fixup! Build bool query params as *bool

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>

Author: sean-

cmd/osgen/emit/build.go

@@ -231,15 +231,11 @@ func buildParamsTestFrag(op *ir.Operation) *ParamsTestFragment {
 	}
 
 	hasDuration := false
-	hasBool := false
 	var cases []ParamTestCase
 	for _, p := range op.QueryParams {
 		if p.Kind == ir.ParamDuration {
 			hasDuration = true
 		}
-		if p.Kind == ir.ParamBool {
-			hasBool = true
-		}
 		tc := ParamTestCase{Name: p.WireName}
 		tc.FieldAssign, tc.WantAssign = paramTestValues(p)
 		cases = append(cases, tc)
@@ -248,7 +244,6 @@ func buildParamsTestFrag(op *ir.Operation) *ParamsTestFragment {
 	return &ParamsTestFragment{
 		TypePrefix:  op.TypePrefix,
 		HasDuration: hasDuration,
-		HasBool:     hasBool,
 		Cases:       cases,
 	}
 }
@@ -263,7 +258,7 @@ func paramTestValues(p ir.QueryParam) (fieldAssign, wantAssign string) {
 		fieldAssign = fmt.Sprintf("%s: 5 * time.Second", p.GoName)
 		wantAssign = fmt.Sprintf("%q: %q", p.WireName, "5000ms")
 	case ir.ParamBool:
-		fieldAssign = fmt.Sprintf("%s: osapitest.Ptr(true)", p.GoName)
+		fieldAssign = fmt.Sprintf("%s: func(b bool) *bool { return &b }(true)", p.GoName)
 		wantAssign = fmt.Sprintf("%q: %q", p.WireName, "true")
 	case ir.ParamList:
 		fieldAssign = fmt.Sprintf(`%s: []string{"a", "b"}`, p.GoName)

cmd/osgen/emit/frag_tests.go

@@ -23,7 +23,6 @@ type ParamTestCase struct {
 type ParamsTestFragment struct {
 	TypePrefix  string
 	HasDuration bool
-	HasBool     bool
 	Cases       []ParamTestCase
 }
 
@@ -35,9 +34,6 @@ func (f *ParamsTestFragment) Imports() []Import {
 	if f.HasDuration {
 		imps = append(imps, Import{Path: "time"})
 	}
-	if f.HasBool {
-		imps = append(imps, Import{Path: "github.com/opensearch-project/opensearch-go/v4/osapi/internal/test", Alias: "osapitest"})
-	}
 	return imps
 }