Commit 44bbc73
gRPC support for opensearch-java (#2062)
* feat: add transparent gRPC transport as separate java-client-grpc module
Adds a transparent gRPC transport layer that routes bulk operations
over gRPC for improved performance while falling back to REST for
all other operations. Isolated in a separate java-client-grpc module
to prevent classpath conflicts.
Includes:
- GrpcTransport + HybridTransport (automatic routing and fallback)
- Translation layer (BulkRequest/Response <-> protobuf conversion)
- TLS support (trust cert, trust store, mTLS, insecure, hostname override)
- Basic auth, AWS SigV4, and JWT authentication interceptors
- Channel health monitoring via gRPC connectivity state machine
- Integration tests (framework-compliant, version-gated to 3.5.0+)
- Sample code and CI configuration
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* ci: retrigger CI
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* Making the FieldMappingUtil package private
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Dayana <jeandayana28@gmail.com>
* Making this package private
Apply suggestion from @reta
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Dayana <jeandayana28@gmail.com>
* Making BasicAuthInterceptor package private
Apply suggestion from @reta
Co-authored-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Dayana <jeandayana28@gmail.com>
* Remove unused toHttpStatus method and fix test package for package-private classes
- Removed GrpcStatusConverter.toHttpStatus() which was unused anywhere
in the codebase (per maintainer feedback)
- Moved TranslationTest to the translation package so it can access
package-private FieldMappingUtil and GrpcStatusConverter.convert()
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* refactor: split AWS SigV4 into AwsGrpcTransport per maintainer feedback
Follows the same pattern as ApacheHttpClient5Transport (general) vs
AwsSdk2Transport (AWS-specific) in the existing codebase.
Changes:
- Created AwsGrpcTransport: extends GrpcTransport, adds SigV4 signing
- AwsGrpcTransport.awsBuilder(host, port).sigV4(...).tls(...).build()
- Requires sigV4Config and TLS
- Overrides preProcessBulk() for payload hash computation
- Removed SigV4 from GrpcTransport:
- Removed .sigV4() builder method
- Removed sigV4Interceptor field
- Added protected preProcessBulk() hook for subclasses
- GrpcTransport is now purely general-purpose (basic auth, JWT, TLS)
- Updated tests to use AwsGrpcTransport for SigV4 tests
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* refactor: remove silent REST fallback from HybridTransport
Per maintainer feedback: if the intent is to use gRPC for a supported
endpoint, errors should propagate to the user rather than silently
falling back to REST.
Changes:
- HybridTransport no longer catches gRPC errors and retries via REST
- Removed fallbackOnError constructor parameter and field
- Routing behavior preserved: unsupported endpoints → REST directly
- gRPC-supported endpoints: errors propagate to caller
- Simplified performRequest/performRequestAsync (no try/catch)
- Updated tests: testGrpcErrorPropagatesForSupportedEndpoint
Behavior:
client.bulk(req) → gRPC (errors propagate if gRPC fails)
client.search(req) → REST (not supported by gRPC, routed directly)
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* docs: update comments to reflect routing instead of fallback
Stale references to 'automatic REST fallback' replaced with accurate
'REST routing for unsupported endpoints' language throughout.
- GrpcTransport: updated javadoc and error message
- GrpcDemo: rewrote Demo 3 to show REST routing (not fallback on error)
- GrpcAwsSigV4: updated to use AwsGrpcTransport.awsBuilder()
- GrpcBulkIT: renamed testRestFallback → testRestRouting
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: make integration test base classes self-contained
Per maintainer feedback: OpenSearchJavaClientTestCase and
TestcontainersThreadFilter are internal test classes not exposed for
external module use.
Changes:
- AbstractGrpcIT: now extends nothing, uses standard JUnit 4 + Assume
- Removed dependency on OpenSearchJavaClientTestCase
- Removed @ThreadLeakFilters(TestcontainersThreadFilter)
- Uses Assume.assumeTrue() with manual version parsing
- Reads cluster config from system properties directly
- GrpcTransportSupport: converted from interface (extending
OpenSearchTransportSupport) to utility class
- GrpcBulkIT: no longer implements GrpcTransportSupport interface
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: lower java-client-grpc baseline from JDK 11 to JDK 8
Per maintainer feedback: opensearch-java baseline is JDK 8 and gRPC-Java
supports Java 8. No technical reason to require JDK 11.
Changes:
- build.gradle.kts: targetCompatibility/sourceCompatibility → 1.8
- GrpcSigV4Test: replaced 'var' (Java 10+) with explicit types
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: remove explicit jackson test deps (transitive via java-client)
Per maintainer feedback: opensearch-java has a hard dependency on
Jackson 3.x, so it comes transitively. No need to declare it again.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: wire up integration tests with java21 source set
Per maintainer feedback: integration tests were not being compiled or
run. Added the standard java21 source set configuration used by
java-client to java-client-grpc.
Changes:
- Added unitTest/integrationTest task definitions
- Added java21 source set (src/test/java11) gated on JDK 21+
- Added test framework, testcontainers, opensearch-testcontainers deps
- Added static import for JUnit Assert in GrpcBulkIT
- Integration tests now compile and will run with:
./gradlew :java-client-grpc:integrationTest -Dtests.opensearch.version=3.5.0
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* ci: add OpenSearch 3.5.0 to integration test matrix
Adds the first gRPC-capable version to the test matrix so the gRPC
integration tests run in CI. Includes both Java 21 and Java 25.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: replace wildcard import with explicit imports (spotless)
Spotless rejects wildcard imports. Replaced 'import static org.junit.Assert.*'
with explicit imports for assertEquals, assertFalse, assertNotNull, assertTrue.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: remove java21 classes from unitTest task
The java21 source set only contains integration tests (integTest package).
Adding it to unitTest causes 'No tests found' failure since the filter
excludes integTest classes. Only integrationTest needs the java21 classes.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: spotless formatting for samples (license header, import order)
- GrpcDemo.java: replaced custom header with standard Apache-2.0 license
- GrpcAwsSigV4.java: fixed import ordering (AwsGrpcTransport alphabetical)
- Removed unused imports
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: skip gRPC integration tests when port is unreachable
assumeGrpcSupported() now verifies both:
1. Server version is 3.5.0+ (via REST info endpoint)
2. gRPC port is actually reachable (TCP socket check)
This prevents test failures when running integrationTest against
OpenSearch versions that don't have gRPC enabled or when the gRPC
port isn't exposed by testcontainers.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: only enable gRPC in testcontainer for OpenSearch 3.5.0+
GrpcTestContainerRule now checks the tests.opensearch.version property
before adding gRPC configuration. Older versions (1.x, 2.x) don't
support aux.transport.types and would fail to start.
On pre-3.5.0 versions:
- Container starts without gRPC config (REST only)
- gRPC port not exposed
- Tests skip via assumeGrpcSupported() (version check + port check)
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* ci: exclude grpc integration tests until OpenSearch 3.5.0 is released
OpenSearch 3.5.0 Docker image is not yet published, so the gRPC
integration tests cannot run in CI. Changes:
- Exclude :java-client-grpc:integrationTest from the main CI run
(all matrix versions are pre-3.5.0)
- Comment out 3.5.0 entries in test matrix (uncomment when released)
The gRPC integration tests can still be run locally against a
container started manually or once 3.5.0 is published.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: graceful skip on container failure + re-enable 3.5.0 in CI
OpenSearch 3.5.0 Docker image is published. Re-enabled in CI matrix.
Changes:
- GrpcTestContainerRule.before(): catches ContainerLaunchException and
calls Assume.assumeTrue(false) to skip tests gracefully instead of
failing the build
- Added 5-minute startup timeout for CI environments
- Removed duplicate disk watermark env var
- Re-enabled 3.5.0 in test-integration.yml matrix
- Removed -x :java-client-grpc:integrationTest exclusion
On pre-3.5.0 versions: container starts without gRPC, tests skip via
assumeGrpcSupported(). On 3.5.0+: if container fails for any reason,
tests skip instead of failing the build.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: spotless formatting on GrpcTestContainerRule
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: remove grpcStatusToHttpStatus from FieldMappingUtil
Per maintainer feedback: method was only used in tests, not in
production code. Removed the method and its 7 associated tests.
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: skip gRPC tests early with assumeTrue for unsupported versions
Per maintainer feedback: use assumeTrue in the class rule to skip
tests immediately for older versions, rather than conditionally
configuring the container.
Changes:
- GrpcTestContainerRule.before(): assumeTrue("OpenSearch should
support gRPC", supportsGrpc(version)) skips for pre-3.5.0
- createContainer(): always configures gRPC (only reached for 3.5.0+)
- Removed conditional gRPC config logic
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: make GrpcChannelFactory methods package-private
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
* fix: apply maintainer suggestions on visibility and naming
1. BasicAuthInterceptor: constructor now package-private
2. GrpcChannelFactory: class now package-private (final class, no public)
3. GrpcTestContainerRule renamed to OpenSearchGrpcTestContainerRule
4. Updated references in AbstractGrpcIT
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
---------
Signed-off-by: Dayana Jean <jeadayao@amazon.com>
Signed-off-by: Dayana <jeandayana28@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com>1 parent 8a8289a commit 44bbc73
37 files changed
Lines changed: 5798 additions & 0 deletions
File tree
- .ci/opensearch
- .github/workflows
- java-client-grpc
- src
- main/java/org/opensearch/client/transport/grpc
- translation
- test
- java11/org/opensearch/client/opensearch/integTest/grpc
- java/org/opensearch/client/transport/grpc
- translation
- samples
- src/main/java/org/opensearch/client/samples
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
9 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
| 34 | + | |
33 | 35 | | |
34 | 36 | | |
35 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
Lines changed: 156 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
0 commit comments