[BUG] ActionRollover min_index_age and min_primary_shard_size data types

[jsatria]

What is the bug?

The min_index_age and min_primary_shard_size are number data types for the ISM plugin ActionRollover action. These should both be strings since a unit must be included. https://github.com/opensearch-project/opensearch-js/blob/main/api/_types/ism._common.d.ts#L87-L88

How can one reproduce the bug?

1. Create an ISM policy with the rollover Action and a min_index_age without a time unit e.g.
2. Put the policy using the ism.putPolicy API
3. You will get an error which includes the following

"root_cause": [
  {
    "type": "illegal_argument_exception",
    "reason": "failed to parse setting [min_index_age] with value [30] as a time value: unit is missing or unrecognized"
  }
],

What is the expected behavior?

The data field should be able to include a time unit.

[nhtruong]

Thanks for catching that. This type originates from the API Spec.

I've created an issue there. Once that's resolved on the spec, the API-codegen will fix this automatically on this client. That seems a simple issue. So feel free to give it a go :)

[hco]

I literally stumbled upon this issue the day after it was fixed in the API Spec :D
Thought I'd let you know: opensearch-project/opensearch-api-specification#974