Skip to content

Commit e6a1103

Browse files
authored
[release-v1.16] Enable new test for SASL keda (#1821)
* Enable new test for SASL keda (knative-extensions#4388) Signed-off-by: Matthias Wessendorf <[email protected]> * Remove extra/double broker install Signed-off-by: Matthias Wessendorf <[email protected]> --------- Signed-off-by: Matthias Wessendorf <[email protected]>
1 parent de4cb72 commit e6a1103

File tree

3 files changed

+46
-2
lines changed

3 files changed

+46
-2
lines changed

test/e2e_new/broker_test.go

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,3 +358,33 @@ func TestBrokerDispatcherKedaScaling(t *testing.T) {
358358

359359
env.Test(ctx, t, features.TriggerScalesToZeroWithKeda())
360360
}
361+
362+
func TestBrokerDispatcherKedaScalingSASL(t *testing.T) {
363+
t.Parallel()
364+
365+
ctx, env := global.Environment(
366+
knative.WithKnativeNamespace(system.Namespace()),
367+
knative.WithLoggingConfig,
368+
knative.WithTracingConfig,
369+
k8s.WithEventListener,
370+
environment.WithPollTimings(5*time.Second, 4*time.Minute),
371+
environment.Managed(t),
372+
)
373+
374+
env.Test(ctx, t, features.TriggerSASLScalesToZeroWithKeda())
375+
}
376+
377+
func TestBrokerDispatcherKedaScalingSSL(t *testing.T) {
378+
t.Parallel()
379+
380+
ctx, env := global.Environment(
381+
knative.WithKnativeNamespace(system.Namespace()),
382+
knative.WithLoggingConfig,
383+
knative.WithTracingConfig,
384+
k8s.WithEventListener,
385+
environment.WithPollTimings(5*time.Second, 4*time.Minute),
386+
environment.Managed(t),
387+
)
388+
389+
env.Test(ctx, t, features.TriggerSSLScalesToZeroWithKeda())
390+
}

test/e2e_new/kafka_source_test.go

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,22 @@ func TestKafkaSourceKedaScaling(t *testing.T) {
242242

243243
}
244244

245+
func TestKafkaSourceKedaScalingSASL(t *testing.T) {
246+
t.Parallel()
247+
248+
ctx, env := global.Environment(
249+
knative.WithKnativeNamespace(system.Namespace()),
250+
knative.WithLoggingConfig,
251+
knative.WithTracingConfig,
252+
k8s.WithEventListener,
253+
environment.WithPollTimings(5*time.Second, 4*time.Minute),
254+
environment.Managed(t),
255+
)
256+
257+
env.Test(ctx, t, features.KafkaSourceSASLScalesToZeroWithKeda())
258+
259+
}
260+
245261
func TestKafkaSourceScaledObject(t *testing.T) {
246262
t.Parallel()
247263

test/rekt/features/keda_scaling.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,6 @@ func TriggerSASLScalesToZeroWithKeda() *feature.Feature {
244244
))
245245

246246
f.Setup("install sink", eventshub.Install(sinkName, eventshub.StartReceiver))
247-
f.Setup("install broker", broker.Install(brokerName))
248247
f.Setup("install trigger", trigger.Install(triggerName, trigger.WithBrokerName(brokerName), trigger.WithSubscriber(service.AsKReference(sinkName), "")))
249248

250249
f.Requirement("install source", eventshub.Install(sourceName, eventshub.StartSenderToResource(broker.GVR(), brokerName), eventshub.InputEvent(event)))
@@ -290,7 +289,6 @@ func TriggerSSLScalesToZeroWithKeda() *feature.Feature {
290289
))
291290

292291
f.Setup("install sink", eventshub.Install(sinkName, eventshub.StartReceiver))
293-
f.Setup("install broker", broker.Install(brokerName))
294292
f.Setup("install trigger", trigger.Install(triggerName, trigger.WithBrokerName(brokerName), trigger.WithSubscriber(service.AsKReference(sinkName), "")))
295293

296294
f.Requirement("install source", eventshub.Install(sourceName, eventshub.StartSenderToResource(broker.GVR(), brokerName), eventshub.InputEvent(event)))

0 commit comments

Comments
 (0)