feat(telco-kpis): Add cross-cutting test infrastructure refactorings

Implement shared roles and modules to eliminate code duplication and standardize
Telco-KPIs test implementations.

## New Roles

**playbooks/telco-kpis/roles/artifact-management/**
- Eliminates duplicate artifact collection code across all tests
- Standardized artifact workflow: collect → generate JUnit XML → push to shared location → cleanup
- Tasks:
  - `collect-from-bastion.yml` - Fetch artifacts from remote bastion
  - `generate-junit-xml.yml` - Create JUnit XML from test results
  - `push-to-shared.yml` - Copy to shared artifact location
  - `cleanup-old-artifacts.yml` - Remove temporary artifacts
- Template: `junit-report.xml.j2` - Standardized JUnit XML format

**playbooks/telco-kpis/roles/telco-kpis-defaults/**
- Centralized default values for all telco-kpis tests
- Provides consistent defaults for:
  - Spirent configuration (chassis, stcweb, ports, test config)
  - Artifact directories
  - Test parameters
- Eliminates hardcoded values scattered across playbooks

## Refactorings Applied

**kubernetes.core Module Migration:**
- Replaced shell commands with kubernetes.core.k8s module for:
  - Pod deployment (dpdk-testpmd)
  - Resource querying
  - Pod deletion verification
- Benefits:
  - Idempotent operations
  - Better error handling
  - Structured return values
  - No shell parsing required

**Centralized Configuration:**
- Default Spirent settings in telco-kpis-defaults role
- Eliminates magic numbers and hardcoded IPs
- Single source of truth for test parameters

## Benefits

- **Code Reuse:** artifact-management role used across all tests
- **Consistency:** Standardized artifact naming and structure
- **Maintainability:** Changes to artifact workflow in one place
- **Reliability:** kubernetes.core modules more robust than shell commands
- **Configuration Management:** Centralized defaults easier to update

## Impact

All telco-kpis tests (oslat, cyclictest, ptp, cpu_util, reboot, rfc2544, bios-validation,
rds-compare, ztp-timeline) benefit from these refactorings.

Related: Telco-KPIs test infrastructure
Signed-off-by: Carlos Cardenosa <ccardeno@redhat.com>

Author: ccardenosa

playbooks/telco-kpis/roles/artifact-management/defaults/main.yml

@@ -0,0 +1,20 @@
+---
+# Default values for artifact-management role
+# These can be overridden when calling the role
+
+# Required parameters (no defaults - must be provided by caller):
+# - artifact_management_test_name
+# - artifact_management_spoke_cluster
+# - artifact_management_temp_dir
+# - artifact_management_test_rc
+
+# Optional parameters with defaults (inherit from telco-kpis-defaults if loaded):
+artifact_management_namespace: "{{ telco_kpis_sriov_namespace | default('openshift-sriov-network-operator') }}"
+artifact_management_shared_base: "{{ telco_kpis_shared_artifact_base | default('/home/telcov10n/telco-kpis-artifacts') }}"
+artifact_management_local_base: "{{ telco_kpis_local_artifact_base | default(lookup('env', 'ARTIFACT_DIR') | default('/artifacts', true)) }}"
+artifact_management_test_duration: "{{ duration_seconds | default('600') }}"
+
+# JUnit XML generation options:
+# - If artifact_management_junit_source_pattern is defined: Search for existing XML and rename it
+# - If not defined: Generate JUnit XML from template
+artifact_management_junit_source_pattern: ""

playbooks/telco-kpis/roles/artifact-management/tasks/cleanup-old-artifacts.yml

@@ -0,0 +1,25 @@
+---
+# Cleanup old test artifacts from shared location (keep only latest run)
+
+- name: Find old artifact directories for this test type
+  ansible.builtin.find:
+    paths: "{{ artifact_management_shared_base }}/{{ artifact_management_spoke_cluster }}"
+    patterns: "{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}-*"
+    file_type: directory
+  register: old_artifact_dirs
+
+- name: Sort artifact directories by timestamp (newest first)
+  ansible.builtin.set_fact:
+    sorted_artifacts: "{{ old_artifact_dirs.files | sort(attribute='path', reverse=True) }}"
+
+- name: Identify artifacts to delete (keep only latest)
+  ansible.builtin.set_fact:
+    artifacts_to_delete: "{{ sorted_artifacts[1:] }}"
+  when: sorted_artifacts | length > 1
+
+- name: Remove old artifact directories
+  ansible.builtin.file:
+    path: "{{ item.path }}"
+    state: absent
+  loop: "{{ artifacts_to_delete | default([]) }}"
+  when: artifacts_to_delete is defined and artifacts_to_delete | length > 0

playbooks/telco-kpis/roles/artifact-management/tasks/collect-from-bastion.yml

@@ -0,0 +1,28 @@
+---
+# Collect artifacts from bastion temporary directory to container /artifacts
+
+- name: List artifacts generated in temp directory
+  ansible.builtin.find:
+    paths: "{{ artifact_management_temp_dir }}"
+    patterns: "*"
+    recurse: yes
+  register: artifact_files
+
+- name: Display artifacts found
+  ansible.builtin.debug:
+    msg: "Artifacts found: {{ artifact_files.files | map(attribute='path') | list }}"
+
+- name: Create local artifact directory
+  ansible.builtin.file:
+    path: "{{ artifact_management_local_base }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}"
+    state: directory
+    mode: '0755'
+  delegate_to: localhost
+
+- name: Fetch artifacts from bastion to local
+  ansible.builtin.fetch:
+    src: "{{ item.path }}"
+    dest: "{{ artifact_management_local_base }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}/"
+    flat: yes
+  loop: "{{ artifact_files.files }}"
+  when: artifact_files.files | length > 0

playbooks/telco-kpis/roles/artifact-management/tasks/generate-junit-xml.yml

@@ -0,0 +1,35 @@
+---
+# Generate JUnit XML report from test results
+
+- name: Search for existing JUnit XML file (if pattern provided)
+  ansible.builtin.find:
+    paths: "{{ artifact_management_local_base }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}"
+    patterns: "{{ artifact_management_junit_source_pattern }}"
+  delegate_to: localhost
+  register: existing_junit_files
+  when: artifact_management_junit_source_pattern is defined and artifact_management_junit_source_pattern | length > 0
+  failed_when: false
+
+- name: Create JUnit format copy for reporter compatibility (rename existing XML)
+  ansible.builtin.copy:
+    src: "{{ existing_junit_files.files[0].path }}"
+    dest: "{{ artifact_management_local_base }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}/junit_{{ artifact_management_test_name }}_{{ artifact_management_spoke_cluster }}.xml"
+    mode: '0644'
+  delegate_to: localhost
+  when:
+    - artifact_management_junit_source_pattern is defined
+    - artifact_management_junit_source_pattern | length > 0
+    - existing_junit_files is defined
+    - existing_junit_files.files | length > 0
+  failed_when: false
+
+- name: Generate JUnit XML report from template (if no existing XML)
+  ansible.builtin.template:
+    src: junit-report.xml.j2
+    dest: "{{ artifact_management_local_base }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}/junit_{{ artifact_management_test_name }}_{{ artifact_management_spoke_cluster }}.xml"
+    mode: '0644'
+  delegate_to: localhost
+  when: >
+    artifact_management_junit_source_pattern is not defined or
+    artifact_management_junit_source_pattern | length == 0 or
+    (existing_junit_files is defined and existing_junit_files.files | length == 0)

playbooks/telco-kpis/roles/artifact-management/tasks/main.yml

@@ -0,0 +1,26 @@
+---
+# Artifact Management Role - Main Entry Point
+# Purpose: Centralized artifact collection, storage, and JUnit XML generation
+
+- name: Validate required parameters
+  ansible.builtin.assert:
+    that:
+      - artifact_management_test_name is defined
+      - artifact_management_spoke_cluster is defined
+      - artifact_management_temp_dir is defined
+      - artifact_management_test_rc is defined
+    fail_msg: |
+      Missing required parameters for artifact-management role.
+      Required: test_name, spoke_cluster, temp_dir, test_rc
+
+- name: Collect artifacts from bastion temp directory
+  ansible.builtin.include_tasks: collect-from-bastion.yml
+
+- name: Push artifacts to shared persistent location
+  ansible.builtin.include_tasks: push-to-shared.yml
+
+- name: Generate JUnit XML report
+  ansible.builtin.include_tasks: generate-junit-xml.yml
+
+- name: Cleanup old artifacts (keep only latest run)
+  ansible.builtin.include_tasks: cleanup-old-artifacts.yml

playbooks/telco-kpis/roles/artifact-management/tasks/push-to-shared.yml

@@ -0,0 +1,19 @@
+---
+# Push artifacts to shared persistent location on bastion
+
+- name: Set timestamp for shared artifact directory
+  ansible.builtin.set_fact:
+    artifact_timestamp: "{{ lookup('pipe', 'date +%Y%m%d-%H%M%S') }}"
+
+- name: Create shared artifact base directory
+  ansible.builtin.file:
+    path: "{{ artifact_management_shared_base }}/{{ artifact_management_spoke_cluster }}"
+    state: directory
+    mode: '0755'
+
+- name: Copy artifacts to shared persistent location
+  ansible.builtin.copy:
+    src: "{{ artifact_management_temp_dir }}/"
+    dest: "{{ artifact_management_shared_base }}/{{ artifact_management_spoke_cluster }}/{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}-{{ artifact_timestamp }}/"
+    remote_src: true
+    mode: '0755'

playbooks/telco-kpis/roles/artifact-management/templates/junit-report.xml.j2

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuites>
+  <testsuite name="{{ artifact_management_test_name }}-{{ artifact_management_spoke_cluster }}" tests="1" failures="{{ '1' if artifact_management_test_rc != 0 else '0' }}" errors="0" time="{{ artifact_management_test_duration }}">
+    <testcase name="{{ artifact_management_test_name | upper }}-{{ artifact_management_spoke_cluster }}" classname="telco.kpis.{{ artifact_management_test_name }}" time="{{ artifact_management_test_duration }}">
+      {% if artifact_management_test_rc != 0 %}
+      <failure message="{{ artifact_management_test_name }} test failed with exit code {{ artifact_management_test_rc }}">
+      Test failed. Check test artifacts for details.
+      </failure>
+      {% endif %}
+    </testcase>
+  </testsuite>
+</testsuites>

playbooks/telco-kpis/roles/telco-kpis-defaults/defaults/main.yml

@@ -0,0 +1,48 @@
+---
+# Telco-KPIs Default Configuration Values
+# These defaults can be overridden at playbook or task level
+
+# Git Repository URLs
+telco_kpis_ran_integration_repo: "https://gitlab.cee.redhat.com/ran/ran-integration.git"
+telco_kpis_ran_integration_branch: "master"
+telco_kpis_cnf_gotests_repo: "https://gitlab.cee.redhat.com/cnf/cnf-gotests.git"
+telco_kpis_cnf_gotests_branch: "master"
+telco_kpis_oslat_repo: "https://gitlab.cee.redhat.com/ran/oslat.git"
+telco_kpis_cyclictest_repo: "https://gitlab.cee.redhat.com/ran/cyclictest.git"
+telco_kpis_telco_reference_repo: "https://github.com/openshift-kni/telco-reference.git"
+telco_kpis_test_scripts_repo: "https://gitlab.cee.redhat.com/ccardeno/telco-kpis-test-local-scripts.git"
+
+# Container Images
+telco_kpis_test_runner_image: "telco-kpis-test-runner:latest"
+telco_kpis_dpdk_testpmd_image: "quay.io/container-perf-tools/dpdk-testpmd"
+
+# OpenShift Namespaces
+telco_kpis_sriov_namespace: "openshift-sriov-network-operator"
+telco_kpis_mco_namespace: "openshift-machine-config-operator"
+
+# Artifact Paths
+telco_kpis_shared_artifact_base: "/home/telcov10n/telco-kpis-artifacts"
+telco_kpis_local_artifact_base: "{{ lookup('env', 'ARTIFACT_DIR') | default('/artifacts', true) }}"
+
+# Default Test Durations
+telco_kpis_default_duration_cyclictest: "12h"
+telco_kpis_default_duration_oslat: "10m"
+telco_kpis_default_duration_ptp: "10m"
+telco_kpis_default_duration_cpu_util: "10m"
+telco_kpis_default_duration_rfc2544: "1h"
+
+# Default Test Parameters
+telco_kpis_default_reboot_count: 6
+telco_kpis_default_frame_size: "256"
+telco_kpis_default_lat_rate: "0.8"
+
+# Spirent RFC2544 Default Configuration
+telco_kpis_default_spirent_chassis: "spt-n4u-mgmt"
+telco_kpis_default_spirent_stcweb: "10.16.231.236:8888"
+telco_kpis_default_spirent_port1: "//spt-n4u-mgmt/2/6"
+telco_kpis_default_spirent_port2: "//spt-n4u-mgmt/2/7"
+telco_kpis_default_spirent_config: "spirent_testcfg.xml"
+
+# Environment Variables
+telco_kpis_git_ssl_no_verify: "true"
+telco_kpis_ran_metrics_url: "https://pushgateway.ran-metrics.telco5g.corp.redhat.com/metrics/job/pipeline1/"