Skip to content

Commit 3fb8352

Browse files
committed
feat: add version check for sno agent
SNO ABI flow will support min 4vCPU in 4.22 and above, so older versions will not pass validation adding check to fail early Added validation to SNOMIN for 4.22 and above Signed-off-by: ehila <ehila@redhat.com>
1 parent 0e95a24 commit 3fb8352

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

common.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,11 +529,15 @@ if [[ ! -z ${AGENT_E2E_TEST_SCENARIO} ]]; then
529529
export NETWORK_TYPE="OVNKubernetes"
530530
export AGENT_PLATFORM_TYPE="${AGENT_PLATFORM_TYPE:-"none"}"
531531
if [[ "${AGENT_PLATFORM_TYPE}" != "external" ]] && [[ "${AGENT_PLATFORM_TYPE}" != "none" ]]; then
532-
echo "Invalid value ${AGENT_PLATFORM_TYPE}, use 'none' or 'external'."
532+
echo "Invalid value ${AGENT_PLATFORM_TYPE}, use 'none' or 'external'."
533533
exit 1
534534
fi
535535
;;
536536
"SNOMIN" )
537+
if is_lower_version "$OPENSHIFT_VERSION" "4.22"; then
538+
echo "SNOMIN is not supported on OCP version lower than 4.22, current version ${OPENSHIFT_VERSION:-\"none provided\"}."
539+
return 1
540+
fi
537541
export NUM_MASTERS=1
538542
export MASTER_VCPU=4
539543
export MASTER_DISK=100

0 commit comments

Comments
 (0)