feat: add version check for sno agent

SNO ABI flow will support min 4vCPU in 4.22 and above, so older versions will not pass validation
adding check to fail early

Removed SNOMIN in favor of setting the default across the board
Added SNOE2E to capture testing where more vcpu is required

Signed-off-by: ehila <ehila@redhat.com>

Author: eggfoobar

common.sh

@@ -521,21 +521,24 @@ if [[ ! -z ${AGENT_E2E_TEST_SCENARIO} ]]; then
           export WORKER_MEMORY=9000
           ;;
       "SNO" )
+          export MASTER_VCPU=4
+          if is_lower_version "$OPENSHIFT_VERSION" "4.22"; then
+              export MASTER_VCPU=8
+          fi
           export NUM_MASTERS=1
-          export MASTER_VCPU=8
           export MASTER_DISK=100
           export MASTER_MEMORY=32768
           export NUM_WORKERS=0
           export NETWORK_TYPE="OVNKubernetes"
           export AGENT_PLATFORM_TYPE="${AGENT_PLATFORM_TYPE:-"none"}"
           if [[ "${AGENT_PLATFORM_TYPE}" != "external" ]]  && [[ "${AGENT_PLATFORM_TYPE}" != "none" ]]; then
-            echo "Invalid value ${AGENT_PLATFORM_TYPE},  use 'none' or 'external'."
+            echo "Invalid value ${AGENT_PLATFORM_TYPE}, use 'none' or 'external'."
             exit 1
           fi
           ;;
-      "SNOMIN" )
+      "SNOE2E" )
           export NUM_MASTERS=1
-          export MASTER_VCPU=4
+          export MASTER_VCPU=8
           export MASTER_DISK=100
           export MASTER_MEMORY=32768
           export NUM_WORKERS=0

config_example.sh

@@ -857,10 +857,10 @@ set -x
 # - SNO_IPV6
 # - SNO_IPV4_DHCP
 # - SNO_IPV6_DHCP
-# - SNOMIN_IPV4
-# - SNOMIN_IPV6
-# - SNOMIN_IPV4_DHCP
-# - SNOMIN_IPV6_DHCP
+# - SNOE2E_IPV4
+# - SNOE2E_IPV6
+# - SNOE2E_IPV4_DHCP
+# - SNOE2E_IPV6_DHCP
 # When set, the code internally sets other low level details such as disk size, memory, number of masters and workers,
 # cpu and ip stack.
 # This config variable is used only by the agent based installer and is required.