Skip to content

Conversation

@oriAdler
Copy link
Contributor

Add a new custom linter to detect OCM logger formatting issues.

@openshift-ci openshift-ci bot requested review from davidleerh and tzvatot November 26, 2025 09:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 26, 2025

Walkthrough

Bumps the package version from 0.1.483 to 0.1.484 and adds a CHANGES.md release entry exposing a new OCM linter and enabling it in the ocm-sdk pipeline.

Changes

Cohort / File(s) Change Summary
Version Update
version.go
Updated public Version constant from "0.1.483" to "0.1.484".
Changelog Entry
CHANGES.md
Added release notes for version 0.1.484 documenting that a new OCM linter is exposed for downstream projects and enabled in the ocm-sdk pipeline.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Release v0.1.484' accurately reflects the main change: a version bump to 0.1.484 as shown in version.go and CHANGES.md.
Description check ✅ Passed The description mentions adding a custom linter for OCM logger formatting issues, which aligns with the CHANGES.md entry about exposing a new OCM linter.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 33c8fda and fa8200d.

📒 Files selected for processing (2)
  • CHANGES.md (1 hunks)
  • version.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • version.go
  • CHANGES.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Test (1.21, macos-latest)
  • GitHub Check: Generate
  • GitHub Check: Test (1.21, windows-latest)
  • GitHub Check: Test (1.21, ubuntu-latest)

Comment @coderabbitai help to get the list of available commands and usage tips.

@nimrodshn
Copy link
Contributor

LGTM 💯

Add a new custom linter to detect OCM logger formatting issues.
@ziccardi
Copy link
Contributor

lgtm

@nimrodshn
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@openshift-ci
Copy link

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nimrodshn, oriAdler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 63720f2 into openshift-online:main Nov 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants