Skip to content

Commit 2cee386

Browse files
haircommanderclaude
haircommander
and
claude
committed
Fix GOMAXPROCS default behavior wording for Go 1.25+
Remove inaccurate parenthetical claiming GOMAXPROCS defaults to the number of CPUs on the node, which is no longer true with Go 1.25's container-aware runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7a7164b commit 2cee386

16 files changed

Lines changed: 18 additions & 26 deletions

‎machineconfiguration/v1/types.go‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -776,7 +776,7 @@ type KubeletConfigSpec struct {
776776
// max(ceil(system_reserved_cpu), 1). This optimizes the runtime parallelism of these Go-based system
777777
// services based on their CPU allocation rather than total node capacity.
778778
// When set to "Disabled", automatic GOMAXPROCS configuration is disabled and the system services
779-
// use Go's default behavior (GOMAXPROCS equals the number of CPUs available on the node).
779+
// use Go's default GOMAXPROCS behavior.
780780
// When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
781781
// The current default is "Disabled".
782782
//
@@ -985,8 +985,7 @@ type ContainerRuntimeConfiguration struct {
985985
// When set to "Autosize", CRI-O will automatically set GOMAXPROCS proportional to the container's CPU request,
986986
// calculated as max(ceil(cpu_request_in_cores * 2), 1). This helps Go applications optimize their runtime parallelism
987987
// based on the allocated CPU resources rather than the total node capacity.
988-
// When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default behavior
989-
// (GOMAXPROCS equals the number of CPUs available on the node).
988+
// When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default GOMAXPROCS behavior.
990989
// When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
991990
// The current default is "Disabled".
992991
//

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-CustomNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ spec:
192192
When set to "Autosize", CRI-O will automatically set GOMAXPROCS proportional to the container's CPU request,
193193
calculated as max(ceil(cpu_request_in_cores * 2), 1). This helps Go applications optimize their runtime parallelism
194194
based on the allocated CPU resources rather than the total node capacity.
195-
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default behavior
196-
(GOMAXPROCS equals the number of CPUs available on the node).
195+
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default GOMAXPROCS behavior.
197196
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
198197
The current default is "Disabled".
199198

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-DevPreviewNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ spec:
192192
When set to "Autosize", CRI-O will automatically set GOMAXPROCS proportional to the container's CPU request,
193193
calculated as max(ceil(cpu_request_in_cores * 2), 1). This helps Go applications optimize their runtime parallelism
194194
based on the allocated CPU resources rather than the total node capacity.
195-
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default behavior
196-
(GOMAXPROCS equals the number of CPUs available on the node).
195+
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default GOMAXPROCS behavior.
197196
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
198197
The current default is "Disabled".
199198

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_containerruntimeconfigs-TechPreviewNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,8 +192,7 @@ spec:
192192
When set to "Autosize", CRI-O will automatically set GOMAXPROCS proportional to the container's CPU request,
193193
calculated as max(ceil(cpu_request_in_cores * 2), 1). This helps Go applications optimize their runtime parallelism
194194
based on the allocated CPU resources rather than the total node capacity.
195-
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default behavior
196-
(GOMAXPROCS equals the number of CPUs available on the node).
195+
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default GOMAXPROCS behavior.
197196
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
198197
The current default is "Disabled".
199198

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-CustomNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ spec:
132132
max(ceil(system_reserved_cpu), 1). This optimizes the runtime parallelism of these Go-based system
133133
services based on their CPU allocation rather than total node capacity.
134134
When set to "Disabled", automatic GOMAXPROCS configuration is disabled and the system services
135-
use Go's default behavior (GOMAXPROCS equals the number of CPUs available on the node).
135+
use Go's default GOMAXPROCS behavior.
136136
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
137137
The current default is "Disabled".
138138
enum:

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-DevPreviewNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ spec:
132132
max(ceil(system_reserved_cpu), 1). This optimizes the runtime parallelism of these Go-based system
133133
services based on their CPU allocation rather than total node capacity.
134134
When set to "Disabled", automatic GOMAXPROCS configuration is disabled and the system services
135-
use Go's default behavior (GOMAXPROCS equals the number of CPUs available on the node).
135+
use Go's default GOMAXPROCS behavior.
136136
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
137137
The current default is "Disabled".
138138
enum:

‎machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_kubeletconfigs-TechPreviewNoUpgrade.crd.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ spec:
132132
max(ceil(system_reserved_cpu), 1). This optimizes the runtime parallelism of these Go-based system
133133
services based on their CPU allocation rather than total node capacity.
134134
When set to "Disabled", automatic GOMAXPROCS configuration is disabled and the system services
135-
use Go's default behavior (GOMAXPROCS equals the number of CPUs available on the node).
135+
use Go's default GOMAXPROCS behavior.
136136
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
137137
The current default is "Disabled".
138138
enum:

‎machineconfiguration/v1/zz_generated.featuregated-crd-manifests/containerruntimeconfigs.machineconfiguration.openshift.io/GomaxprocsInjection.yaml‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ spec:
6161
When set to "Autosize", CRI-O will automatically set GOMAXPROCS proportional to the container's CPU request,
6262
calculated as max(ceil(cpu_request_in_cores * 2), 1). This helps Go applications optimize their runtime parallelism
6363
based on the allocated CPU resources rather than the total node capacity.
64-
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default behavior
65-
(GOMAXPROCS equals the number of CPUs available on the node).
64+
When set to "Disabled", GOMAXPROCS injection is disabled and containers will use Go's default GOMAXPROCS behavior.
6665
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
6766
The current default is "Disabled".
6867

‎machineconfiguration/v1/zz_generated.featuregated-crd-manifests/kubeletconfigs.machineconfiguration.openshift.io/GomaxprocsInjection.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ spec:
132132
max(ceil(system_reserved_cpu), 1). This optimizes the runtime parallelism of these Go-based system
133133
services based on their CPU allocation rather than total node capacity.
134134
When set to "Disabled", automatic GOMAXPROCS configuration is disabled and the system services
135-
use Go's default behavior (GOMAXPROCS equals the number of CPUs available on the node).
135+
use Go's default GOMAXPROCS behavior.
136136
When omitted, this means no opinion and the platform is left to choose a reasonable default, which is subject to change over time.
137137
The current default is "Disabled".
138138
enum:

‎machineconfiguration/v1/zz_generated.swagger_doc_generated.go‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)