CONSOLE-4492: Clean up unused CSS

Author: logonoff

Diff for: frontend/package.json

@@ -140,7 +140,7 @@
     "@patternfly/react-catalog-view-extension": "^6.1.0",
     "@patternfly/react-charts": "^8.2.1",
     "@patternfly/react-code-editor": "^6.2.1",
-    "@patternfly/react-component-groups": "6.2.1",
+    "@patternfly/react-component-groups": "^6.2.1",
     "@patternfly/react-console": "^6.0.0",
     "@patternfly/react-core": "^6.2.1",
     "@patternfly/react-icons": "^6.2.1",

Diff for: frontend/packages/console-app/src/components/volume-snapshot/create-volume-snapshot/create-volume-snapshot.tsx

@@ -252,7 +252,7 @@ const CreateSnapshotForm = withHandlePromise<SnapshotResourceProps>((props) => {
       <div className="co-m-pane__form">
         <DocumentTitle>{title}</DocumentTitle>
         <PageHeading
-          title={<div className="co-m-pane__name">{title}</div>}
+          title={title}
           linkProps={{
             component: LinkTo(
               `/k8s/ns/${namespace || 'default'}/${referenceForModel(VolumeSnapshotModel)}/~new`,

Diff for: frontend/packages/console-shared/src/components/multi-tab-list/MultiTabListPage.tsx

@@ -87,8 +87,8 @@ const MultiTabListPage: React.FC<MultiTabListPageProps> = ({
                 </Button>
               </ActionListItem>
             )}
-            <ActionListItem>
-              {items && (
+            {items && (
+              <ActionListItem>
                 <Dropdown
                   buttonClassName="pf-m-primary"
                   menuClassName="prevent-overflow"
@@ -97,8 +97,8 @@ const MultiTabListPage: React.FC<MultiTabListPageProps> = ({
                   items={items}
                   onChange={onSelectCreateAction}
                 />
-              )}
-            </ActionListItem>
+              </ActionListItem>
+            )}
           </>
         }
       />

Diff for: frontend/packages/dev-console/src/components/add/AddPageLayout.tsx

@@ -5,7 +5,7 @@ import { useTranslation } from 'react-i18next';
 import { AddActionGroup, isAddActionGroup } from '@console/dynamic-plugin-sdk';
 import { GettingStartedSection } from '@console/internal/components/dashboard/project-dashboard/getting-started/GettingStartedSection';
 import { getQueryArgument, BasePageHeading } from '@console/internal/components/utils';
-import { useExtensions } from '@console/plugin-sdk/src';
+import { useExtensions } from '@console/plugin-sdk/src/api/useExtensions';
 import { useActiveNamespace } from '@console/shared';
 import TopologyQuickSearch from '@console/topology/src/components/quick-search/TopologyQuickSearch';
 import TopologyQuickSearchButton from '@console/topology/src/components/quick-search/TopologyQuickSearchButton';
@@ -103,8 +103,9 @@ const AddPageLayout: React.FC<AddPageLayoutProps> = ({ title }) => {
 
   return (
     <div className="odc-add-page-layout ocs-quick-search-modal__no-backdrop" data-test="add-page">
-      <BasePageHeading title={title} helpText={<HelpText />} />
+      <BasePageHeading title={title} />
       <PageSection>
+        <HelpText />
         <GettingStartedSection userSettingKey="devconsole.addPage.gettingStarted" />
         <AddCardSection
           addActionExtensions={filteredAddActionExtensions}

Diff for: frontend/packages/dev-console/src/components/add/__tests__/AddPageLayout.spec.tsx

@@ -9,8 +9,7 @@ import { useShowAddCardItemDetails } from '../hooks/useShowAddCardItemDetails';
 import { addActionExtensions } from './add-page-test-data';
 
 jest.mock('@console/plugin-sdk/src/api/useExtensions', () => {
-  const addActionGroupExtensions = jest.requireActual('./add-page-test-data');
-  return { useExtensions: () => addActionGroupExtensions };
+  return { useExtensions: () => [] };
 });
 
 jest.mock('../hooks/useShowAddCardItemDetails', () => ({

Diff for: frontend/packages/gitops-plugin/src/components/details/GitOpsDetailsPageHeading.scss

@@ -2,7 +2,6 @@ import * as React from 'react';
 import { useTranslation } from 'react-i18next';
 import { routeDecoratorIcon } from '@console/dev-console/src/components/import/render-utils';
 import { BasePageHeading } from '@console/internal/components/utils/headings';
-import './GitOpsDetailsPageHeading.scss';
 
 interface GitOpsDetailsPageHeadingProps {
   url: string;

Diff for: frontend/packages/gitops-plugin/src/components/details/GitOpsDetailsPageHeading.tsx

@@ -18,6 +18,6 @@ export const overviewPage = {
     cy.get('.resource-overview').should(exist ? 'exist' : 'not.exist');
   },
   detailsSidebarHeadingContains: (name) => {
-    cy.get('.resource-overview__heading .co-m-pane__name').contains(name);
+    cy.get('.resource-overview__heading .co-m-pane__heading').contains(name);
   },
 };

Diff for: frontend/packages/integration-tests-cypress/views/overview.ts

@@ -226,7 +226,7 @@ export const eventingPO = {
     noApp: '[id="#UNASSIGNED_APP#-link"]',
     appName: '[data-test-id="application-form-app-name"]',
     eventSourceLink: '[data-type="event-source-link"]',
-    headingTitle: '.resource-overview__heading',
+    headingTitle: '.resource-overview [data-test-id="resource-title"]',
     listItem: '.list-group-item',
   },
   eventSource: {

Diff for: frontend/packages/knative-plugin/integration-tests/support/pageObjects/global-po.ts

@@ -1,6 +1,6 @@
 /* eslint-disable @typescript-eslint/no-use-before-define */
 import * as React from 'react';
-import { Button, TextInput, TextInputProps } from '@patternfly/react-core';
+import { Button, PageSection, TextInput, TextInputProps } from '@patternfly/react-core';
 import classNames from 'classnames';
 // eslint-disable-next-line no-restricted-imports
 import * as _ from 'lodash-es';
@@ -315,7 +315,16 @@ export const FireMan: React.FC<FireManProps & { filterList?: typeof filterList }
 
   return (
     <>
-      <PageHeading title={title} badge={badge} helpText={helpText} primaryAction={createLink} />
+      {/* Badge rendered from PageHeading only when title is present */}
+      {title && (
+        <PageHeading title={title} badge={badge} helpText={helpText} primaryAction={createLink} />
+      )}
+      {!title && (
+        <PageSection>
+          {createLink}
+          {badge && <div>{badge}</div>}
+        </PageSection>
+      )}
       <PaneBody>
         {inject(props.children, {
           resources,

Diff for: frontend/packages/pipelines-plugin/src/components/ListPage.tsx

@@ -4,8 +4,6 @@ import { BasePageHeading } from '@console/internal/components/utils/headings';
 import { TechPreviewBadge } from '@console/shared';
 import { usePipelineTechPreviewBadge } from '../../../utils/hooks';
 
-import './PipelineBuilderHeader.scss';
-
 const PipelineBuilderHeader: React.FC<{ namespace: string }> = ({ namespace }) => {
   const { t } = useTranslation();
   const badge = usePipelineTechPreviewBadge(namespace);
@@ -14,6 +12,7 @@ const PipelineBuilderHeader: React.FC<{ namespace: string }> = ({ namespace }) =
     <BasePageHeading
       title={t('pipelines-plugin~Pipeline builder')}
       badge={badge && <TechPreviewBadge />}
+      hideFavoriteButton
     />
   );
 };

Diff for: frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/PipelineBuilderHeader.scss

@@ -6,8 +6,6 @@ import { TaskKind } from '../../../../types';
 import PipelineResourceRef from '../../../shared/common/PipelineResourceRef';
 import TaskSidebarShortcuts from './TaskSidebarShortcuts';
 
-import './TaskSidebarHeader.scss';
-
 type TaskSidebarHeaderProps = {
   removeThisTask: () => void;
   taskResource: TaskKind;

Diff for: frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/PipelineBuilderHeader.tsx

@@ -90,7 +90,7 @@ export const topologyPO = {
     podScaleUP: '[aria-label="Increase the Pod count"]',
     podScaleDown: '[aria-label="Decrease the Pod count"]',
     podText: 'text.pod-ring__center-text',
-    applicationGroupingsTitle: '.overview__sidebar-pane-head.resource-overview__heading',
+    applicationGroupingsTitle: '.overview__sidebar-pane-head data-test-id="resource-title"]',
     applicationGroupingsSidepane: 'overview__sidebar-pane resource-overview',
     resourcesTabApplicationGroupings: '.pf-v6-c-tabs__item',
     pipelineRunsDetails: '.sidebar__section-heading',

Diff for: frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/task-sidebar/TaskSidebarHeader.scss

@@ -1,4 +1,6 @@
 .odc-topology-sidebar-alert,
 .dc-deprecation-sidebar-alert {
-  margin: 0 20px var(--pf-t--global--spacer--md);
+  &:empty {
+    display: none;
+  }
 }

Diff for: frontend/packages/pipelines-plugin/src/components/pipelines/pipeline-builder/task-sidebar/TaskSidebarHeader.tsx

@@ -178,7 +178,7 @@ export const PageHeading = connectToModel((props: PageHeadingProps) => {
           <OverrideTitle obj={data} />
         ) : (
           (kind || resourceTitle || resourceStatus) && (
-            <div className="co-m-pane__heading co-m-pane__name co-resource-item">
+            <div className="co-m-pane__heading co-resource-item">
               {kind && <ResourceIcon kind={kind} className="co-m-resource-icon--lg" />}{' '}
               <span data-test-id="resource-title" className="co-resource-item__resource-name">
                 {resourceTitle}

Diff for: frontend/packages/topology/integration-tests/support/page-objects/topology-po.ts

@@ -1452,7 +1452,7 @@
   "(use all containers)": "(use all containers)",
   "Select which containers to mount volume into.": "Select which containers to mount volume into.",
   "Add Storage": "Add Storage",
-  "<0>Add Storage</0><1> to <3></3></1>": "<0>Add Storage</0><1> to <3></3></1>",
+  "<0> to <3></3></0>": "<0> to <3></3></0>",
   "Storage type": "Storage type",
   "Access mode is set by StorageClass and cannot be changed": "Access mode is set by StorageClass and cannot be changed",
   "Permissions to the mounted drive": "Permissions to the mounted drive",

Diff for: frontend/packages/topology/src/components/side-bar/components/SideBarHeading.scss

@@ -1773,7 +1773,7 @@
     react-dropzone "14.3.5"
     tslib "^2.8.1"
 
-"@patternfly/[email protected]":
+"@patternfly/react-component-groups@^6.2.1":
   version "6.2.1"
   resolved "https://registry.yarnpkg.com/@patternfly/react-component-groups/-/react-component-groups-6.2.1.tgz#2b4d184d128426c9b72366c0da4fa5c488febd06"
   integrity sha512-bPiPoVOR+mS3xdMpAv/xkbT9+PVvNhfE22JdUG2pfmWXXTP7BsmFgRo4mouSDqqDTdXz+ZDYKRkxGR5FpKMJyQ==