From 150a2091454b2fd86a8d23f8772e247edd89042e Mon Sep 17 00:00:00 2001 From: Lokananda Prabhu Date: Thu, 24 Apr 2025 16:35:28 +0530 Subject: [PATCH] Added patternfly/react-topology to shared module list of dynamic plugin sdk --- frontend/packages/console-dynamic-plugin-sdk/README.md | 3 +++ .../src/shared-modules/shared-modules-init.ts | 1 + .../src/shared-modules/shared-modules-meta.ts | 2 ++ 3 files changed, 6 insertions(+) diff --git a/frontend/packages/console-dynamic-plugin-sdk/README.md b/frontend/packages/console-dynamic-plugin-sdk/README.md index 34527db86a6..532f8b88b75 100644 --- a/frontend/packages/console-dynamic-plugin-sdk/README.md +++ b/frontend/packages/console-dynamic-plugin-sdk/README.md @@ -129,6 +129,7 @@ The following shared modules are provided by Console, without plugins providing - `@openshift-console/dynamic-plugin-sdk` - `@openshift-console/dynamic-plugin-sdk-internal` +- `@patternfly/react-topology` - `react` - `react-i18next` - `react-redux` @@ -175,6 +176,8 @@ This section documents notable changes in the Console provided shared modules ac `react-router-dom-v5-compat` will be removed in the future. Plugins should continue migration to the `react-router-dom-v5-compat` module until `react-router-dom` v6 is aliased to `react-router-dom` v6. See the [Official v5 to v6 Migration Guide](https://reactrouter.com/6.30.0/upgrading/v5) for details. +- Added `@patternfly/react-topology` to shared modules. This supports dynamic plugins using PatternFly 6 + topology components with consistent context and styling. ##### CSS styling diff --git a/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-init.ts b/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-init.ts index daf187af25f..11f6a41ad9c 100644 --- a/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-init.ts +++ b/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-init.ts @@ -35,6 +35,7 @@ const initSharedScope = () => { addModule('@openshift-console/dynamic-plugin-sdk-internal', async () => () => require('@console/dynamic-plugin-sdk/src/lib-internal'), ); + addModule('@patternfly/react-topology', async () => () => require('@patternfly/react-topology')); addModule('react', async () => () => require('react')); addModule('react-i18next', async () => () => require('react-i18next')); addModule('react-redux', async () => () => require('react-redux')); diff --git a/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-meta.ts b/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-meta.ts index 3fa9a490d09..d837b8c6f61 100644 --- a/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-meta.ts +++ b/frontend/packages/console-dynamic-plugin-sdk/src/shared-modules/shared-modules-meta.ts @@ -24,6 +24,7 @@ type SharedModuleMetadata = Partial<{ export const sharedPluginModules = [ '@openshift-console/dynamic-plugin-sdk', '@openshift-console/dynamic-plugin-sdk-internal', + '@patternfly/react-topology', 'react', 'react-i18next', 'react-redux', @@ -42,6 +43,7 @@ export type SharedModuleNames = typeof sharedPluginModules[number]; const sharedPluginModulesMetadata: Record = { '@openshift-console/dynamic-plugin-sdk': { singleton: true, allowFallback: false }, '@openshift-console/dynamic-plugin-sdk-internal': { singleton: true, allowFallback: false }, + '@patternfly/react-topology': { singleton: true, allowFallback: false }, react: { singleton: true, allowFallback: false }, 'react-i18next': { singleton: true, allowFallback: false }, 'react-redux': { singleton: true, allowFallback: false },