Skip to content

Commit e044f84

Browse files
Merge pull request #1459 from bharath-b-rh/cfe-916
CFE-916: Update TechPreview limitations for GCP tags support
2 parents b19db47 + 9f2a516 commit e044f84

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

enhancements/api-review/gcp_user_defined_labels.md

+14-8
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ approvers:
1313
api-approvers:
1414
- "@JoelSpeed" ## approver for api component
1515
creation-date: 2022-07-12
16-
last-updated: 2023-08-01
16+
last-updated: 2023-08-23
1717
tracking-link:
1818
- https://issues.redhat.com/browse/OCPPLAN-8155
1919
- https://issues.redhat.com/browse/CORS-2455
@@ -387,8 +387,8 @@ is immutable.
387387
OpenShift operators(Cluster Infrastructure, Storage) that create GCP resources will apply
388388
these tags to all GCP resources they create.
389389

390-
Resources which support tags and is required by OpenShift are Compute Engine Instances,
391-
Cloud Storage Buckets.
390+
Resources which support tags and is required by OpenShift are Compute VM Instances,
391+
Compute Disks, Compute Images, Compute Snapshots, Filestore Instances and Cloud Storage Buckets.
392392

393393
Tag operations are restricted through quotas and the quota for tag write operation
394394
`TagsWriteRequestsPerMinutePerProject` has a default limit of 600requests/minute. Rate limit
@@ -500,11 +500,13 @@ func() {
500500
respectively of `infrastructure.config.openshift.io/v1` resource will result in adding
501501
labels and tags to all OpenShift managed GCP resources.
502502
3. Limitations for TechPreview
503-
- Worker compute machines created by `machine-api-provider-gcp` controller will not be tagged,
504-
controller will be replaced with cluster-api-provider-gcp, and requires tagging
503+
- Compute VM Instances(master machines) and Cloud Storage Bucket created by `installer` will
504+
not be tagged.
505+
- Compute VM Instances(worker machines) created by `machine-api-provider-gcp` controller will
506+
not be tagged, controller will be replaced with cluster-api-provider-gcp, and requires tagging
505507
support to be added in upstream.
506-
- Disk, Images, Snapshots created by `gcp-pd-csi-driver` will not be tagged with the userTags,
507-
requires tagging support to be added in upstream.
508+
- Compute Disk, Compute Images, Compute Snapshots created by `gcp-pd-csi-driver` will not be
509+
tagged with the userTags, requires tagging support to be added in upstream.
508510
- Filestore Instance resource created by `gcp-filestore-csi-driver` will not be tagged with
509511
the userTags, requires tagging support to be added in upstream.
510512

@@ -544,8 +546,12 @@ func() {
544546
operator. In this proposal, the changes proposed and developed will be part of
545547
openshift-* namespace. External operators are not in scope.
546548
User-defined tags can be updated on the following GCP resources.
547-
- Compute Engine Instances
549+
- Compute VM Instances
550+
- Compute Disks
551+
- Compute Images
552+
- Compute Snapshots
548553
- Cloud Storage Buckets
554+
- Filestore Instances
549555

550556
- Administrator will have to manually perform below label pertaining actions
551557
1. removing the undesired labels/tags from the required resources.

0 commit comments

Comments
 (0)