Merge pull request #10663 from ankimaha-sys/fix-vsphere-username-error-message

openshift-merge-bot[bot] · web-flow · commit 6d13655fad7a · 2026-07-02T21:28:26.000Z
no-jira: fix vCenter validation error to use correct field name
diff --git a/pkg/types/vsphere/validation/platform.go b/pkg/types/vsphere/validation/platform.go
@@ -143,7 +143,7 @@ func validateVCenters(p *vsphere.Platform, fldPath *field.Path) field.ErrorList
 			}
 		}
 		if len(vCenter.Username) == 0 {
-			allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("username"), "must specify the username"))
+			allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("user"), "must specify the user"))
 		}
 		if len(vCenter.Password) == 0 {
 			allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("password"), "must specify the password"))
diff --git a/pkg/types/vsphere/validation/platform_test.go b/pkg/types/vsphere/validation/platform_test.go
@@ -455,7 +455,7 @@ func TestValidatePlatform(t *testing.T) {
 				p.VCenters[0].Username = ""
 				return p
 			}(),
-			expectedError: `^test-path\.vcenters\[0].username: Required value: must specify the username$`,
+			expectedError: `^test-path\.vcenters\[0].user: Required value: must specify the user$`,
 		},
 		{
 			name: "Multi-zone missing password",

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,7 @@ func validateVCenters(p vsphere.Platform, fldPath field.Path) field.ErrorList`
`143`	`143`	`}`
`144`	`144`	`}`
`145`	`145`	`if len(vCenter.Username) == 0 {`
`146`		`- allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("username"), "must specify the username"))`
	`146`	`+ allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("user"), "must specify the user"))`
`147`	`147`	`}`
`148`	`148`	`if len(vCenter.Password) == 0 {`
`149`	`149`	`allErrs = append(allErrs, field.Required(fldPath.Index(index).Child("password"), "must specify the password"))`
Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ func TestValidatePlatform(t *testing.T) {`
`455`	`455`	`p.VCenters[0].Username = ""`
`456`	`456`	`return p`
`457`	`457`	`}(),`
`458`		- expectedError: `^test-path\.vcenters\[0].username: Required value: must specify the username$`,
	`458`	+ expectedError: `^test-path\.vcenters\[0].user: Required value: must specify the user$`,
`459`	`459`	`},`
`460`	`460`	`{`
`461`	`461`	`name: "Multi-zone missing password",`