pkg/types/azure: remove SystemAssignedID docs

For the Azure identity API, the installer makes use directly of the
CAPZ API, but we do add validation to not support SystemAssigned
identities.

SystemAssigned identities were removed in
11f006d
but I missed updating the godoc text which is pulled in from CAPZ.

This PR updates the godoc text and kubebuilder annotations so that the
explain command will not show SystemAssigned identities as a valid choice.

Author: patrickdillon

data/data/install.openshift.io_installconfigs.yaml

@@ -252,8 +252,6 @@ spec:
                         default: None
                         description: |-
                           Identity is the type of identity used for the virtual machine.
-                          The type 'SystemAssigned' is an implicitly created identity.
-                          The generated identity will be assigned a Subscription contributor role.
                           The type 'UserAssigned' is a standalone Azure resource provided by the user
                           and assigned to the VM
                           Identity can only be set for control-plane nodes.
@@ -263,7 +261,6 @@ spec:
                               used.
                             enum:
                             - None
-                            - SystemAssigned
                             - UserAssigned
                             type: string
                           userAssignedIdentities:
@@ -1574,8 +1571,6 @@ spec:
                           default: None
                           description: |-
                             Identity is the type of identity used for the virtual machine.
-                            The type 'SystemAssigned' is an implicitly created identity.
-                            The generated identity will be assigned a Subscription contributor role.
                             The type 'UserAssigned' is a standalone Azure resource provided by the user
                             and assigned to the VM
                             Identity can only be set for control-plane nodes.
@@ -1585,7 +1580,6 @@ spec:
                                 be used.
                               enum:
                               - None
-                              - SystemAssigned
                               - UserAssigned
                               type: string
                             userAssignedIdentities:
@@ -2835,8 +2829,6 @@ spec:
                         default: None
                         description: |-
                           Identity is the type of identity used for the virtual machine.
-                          The type 'SystemAssigned' is an implicitly created identity.
-                          The generated identity will be assigned a Subscription contributor role.
                           The type 'UserAssigned' is a standalone Azure resource provided by the user
                           and assigned to the VM
                           Identity can only be set for control-plane nodes.
@@ -2846,7 +2838,6 @@ spec:
                               used.
                             enum:
                             - None
-                            - SystemAssigned
                             - UserAssigned
                             type: string
                           userAssignedIdentities:
@@ -4570,8 +4561,6 @@ spec:
                         default: None
                         description: |-
                           Identity is the type of identity used for the virtual machine.
-                          The type 'SystemAssigned' is an implicitly created identity.
-                          The generated identity will be assigned a Subscription contributor role.
                           The type 'UserAssigned' is a standalone Azure resource provided by the user
                           and assigned to the VM
                           Identity can only be set for control-plane nodes.
@@ -4581,7 +4570,6 @@ spec:
                               used.
                             enum:
                             - None
-                            - SystemAssigned
                             - UserAssigned
                             type: string
                           userAssignedIdentities:

pkg/types/azure/machinepool.go

@@ -72,8 +72,6 @@ type MachinePool struct {
 	Settings *SecuritySettings `json:"settings,omitempty"`
 
 	// Identity is the type of identity used for the virtual machine.
-	// The type 'SystemAssigned' is an implicitly created identity.
-	// The generated identity will be assigned a Subscription contributor role.
 	// The type 'UserAssigned' is a standalone Azure resource provided by the user
 	// and assigned to the VM
 	// Identity can only be set for control-plane nodes.
@@ -264,6 +262,9 @@ type OSImage struct {
 // VMIdentity configures the identity attached to the VM.
 type VMIdentity struct {
 	// Type specifies the type of identity to be used.
+	// +kubebuilder:validation:Schemaless
+	// +kubebuilder:validation:Type=string
+	// +kubebuilder:validation:Enum=None;UserAssigned
 	Type capz.VMIdentity `json:"type"`
 
 	// UserAssignedIdentities is a list of identities to be attached to a node.