USHIFT-5531: Auto-rebase procedure with flannel and kube-proxy image update #4726
Conversation
|
@praveenkumar: This pull request references USHIFT-5531 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
praveenkumar
changed the title
praveenkumar
force-pushed
the
issue_5531
branch
4 times, most recently
from
124b1ca to
5d95c73
Compare
|
/test ? |
|
@ggiguash: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ggiguash Do we need any other test than default running ones? |
Yes I was checking that and looks like still ignored so may be https://github.com/openshift/microshift/blob/main/scripts/auto-rebase/assets.yaml#L268-L296 also need to updated? |
scripts/auto-rebase/rebase.py
Outdated
| @@ -102,6 +102,23 @@ def run_rebase_ai_model_serving_sh(release): | |||
| return RebaseScriptResult(success=result.returncode == 0, output=result.stdout) | |||
|
|
|||
|
|
|||
| def run_rebase_flannel(): | |||
There was a problem hiding this comment.
Should this function be executed?
I recall that newest flannel requires a kernel module, should we even proceed with this PR?
There was a problem hiding this comment.
@pmtk I just removed that commit, so whatever we choose for CNI which doesn't require any kernel module then will check how that component need to be rebased.
| @@ -1118,6 +1119,44 @@ EOF | |||
| done # for goarch | |||
| } | |||
|
|
|||
| update_kubeproxy_images() { | |||
There was a problem hiding this comment.
Do you know what's the difference between kube-proxy and kube-rbac-proxy? Can they be used interchangeably?
There was a problem hiding this comment.
AI tells below difference and i don't think it can be use interchangeably.
kube-proxy
Purpose:
Manages networking rules on each node to route traffic to the appropriate pods.
Key Role:
Handles network routing for services in a Kubernetes cluster.
Runs on each node.
Uses either iptables, ipvs, or userspace to forward traffic to pod IPs behind a service.
kube-rbac-proxy
Purpose:
Provides an authentication and authorization layer (based on Kubernetes RBAC) in front of an HTTP server (e.g., metrics endpoint).
Key Role:
Runs as a sidecar or standalone proxy.
Forwards requests only if the user is authorized per Kubernetes RBAC policies.
Often used with metrics endpoints (like Prometheus scraping metrics from controllers or custom services).
5d95c73 to
6306d42
Compare
praveenkumar
force-pushed
the
issue_5531
branch
from
6306d42 to
df1f76d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmtk, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
1 similar comment
|
/retest |
|
@praveenkumar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Which issue(s) this PR addresses:
Closes #