Add e2e backup and restore test suite for oadp-cli (#1835)

* start cli e2e work

* First pass done

* Install oadp-cli in CI image

* Fix linting

* Refactor code

* Add kubectl

* Add TEST_CLI option to Makefile and update testing documentation

- Introduced TEST_CLI variable to control CLI-based backup/restore testing in the Makefile.
- Updated TESTING.md to include information about the new TEST_CLI environment variable.
- Added 'cli' label to the CLI test suite for better categorization.

* Manual oadp-cli build and mv

* Fail cli e2e if oadp not found

* Add logging before cli commands execute

* fix

* Tabs not spaces

Author: Joeavaikath

Makefile

@@ -731,6 +731,7 @@ ARTIFACT_DIR ?= /tmp
 HCO_UPSTREAM ?= false
 TEST_VIRT ?= false
 TEST_HCP ?= false
+TEST_CLI ?= false
 SKIP_MUST_GATHER  ?= false
 TEST_UPGRADE ?= false
 TEST_FILTER = (($(shell echo '! aws && ! gcp && ! azure && ! ibmcloud' | \
@@ -751,6 +752,11 @@ ifeq ($(TEST_HCP),true)
 else
 	TEST_FILTER += && (! hcp)
 endif
+ifeq ($(TEST_CLI),true)
+	TEST_FILTER += && (cli)
+else
+	TEST_FILTER += && (! cli)
+endif
 
 .PHONY: test-e2e
 test-e2e: test-e2e-setup install-ginkgo ## Run E2E tests against OADP operator installed in cluster. For more information, check docs/developer/testing/TESTING.md

build/ci-Dockerfile

@@ -5,6 +5,19 @@ WORKDIR /go/src/github.com/openshift/oadp-operator
 
 COPY ./ .
 
+# Clone and install oadp-cli
+RUN git clone https://github.com/migtools/oadp-cli.git /tmp/oadp-cli && \
+    cd /tmp/oadp-cli && \
+    make build && \
+    cp kubectl-oadp /usr/local/bin/ && \
+    chmod +x /usr/local/bin/kubectl-oadp; \
+    rm -rf /tmp/oadp-cli
+
+# Install kubectl
+RUN curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl" && \
+    chmod +x kubectl && \
+    mv kubectl /usr/local/bin/
+
 RUN go mod download && \
     mkdir -p $(go env GOCACHE) && \
     chmod -R 777 ./ $(go env GOCACHE) $(go env GOPATH)

docs/developer/testing/TESTING.md

@@ -23,6 +23,7 @@ To get started, you need to provide the following **required** environment varia
 | `OPENSHIFT_CI` | Disable colored output from tests suite run | `true` | false |
 | `TEST_VIRT` | Exclusively run Virtual Machine backup/restore testing | `false` | false |
 | `TEST_UPGRADE` | Exclusively run upgrade tests. Need to first run `make catalog-test-upgrade`, if testing non production operator | `false` | false |
+| `TEST_CLI` | Exclusively run CLI-based backup/restore testing | `false` | false |
 | `SKIP_MUST_GATHER` | must-gather is compiled locally in the Makefile, may cause issue if local and cluster arch do not match| `false` | false |
 
 > **Note:**