add daemonset and deployment hooks for per node volume limit

Since NodeChecker now checks max attachment limit value it is now safe
to add hooks for reflecting maxAllowedBlockVolumesPerNode field of
clusterCSIDriver into deployment and daemonset as env variable.

Author: RomanBednar

pkg/operator/vspherecontroller/driver_starter.go

@@ -4,13 +4,16 @@ import (
 	"context"
 	"crypto/sha256"
 	"fmt"
+	"github.com/openshift/api/features"
 	"os"
+	"strconv"
 
 	"github.com/openshift/library-go/pkg/operator/resource/resourcehash"
 	"github.com/openshift/vmware-vsphere-csi-driver-operator/pkg/operator/utils"
 
 	operatorapi "github.com/openshift/api/operator/v1"
 	"github.com/openshift/library-go/pkg/controller/factory"
+	"github.com/openshift/library-go/pkg/operator/configobserver/featuregates"
 	"github.com/openshift/library-go/pkg/operator/csi/csicontrollerset"
 	"github.com/openshift/library-go/pkg/operator/csi/csidrivercontrollerservicecontroller"
 	"github.com/openshift/library-go/pkg/operator/csi/csidrivernodeservicecontroller"
@@ -23,6 +26,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	corev1informers "k8s.io/client-go/informers/core/v1"
 	"k8s.io/klog/v2"
+
+	operatorlistersv1 "github.com/openshift/client-go/operator/listers/operator/v1"
 )
 
 func (c *VSphereController) createCSIDriver() {
@@ -135,6 +140,7 @@ func (c *VSphereController) createCSIDriver() {
 			c.apiClients.SecretInformer,
 		),
 		csidrivercontrollerservicecontroller.WithReplicasHook(c.apiClients.ConfigInformers),
+		WithMaxVolumesPerNodeDeploymentHook(c.apiClients.ClusterCSIDriverInformer.Lister(), c.featureGates),
 	).WithCSIDriverNodeService(
 		"VMwareVSphereDriverNodeServiceController",
 		assets.ReadFile,
@@ -150,6 +156,7 @@ func (c *VSphereController) createCSIDriver() {
 			c.apiClients.ConfigMapInformer,
 		),
 		WithSecretDaemonSetAnnotationHook(driverConfigSecretName, defaultNamespace, c.apiClients.SecretInformer),
+		WithMaxVolumesPerNodeDaemonSetHook(c.apiClients.ClusterCSIDriverInformer.Lister(), c.featureGates),
 	).WithServiceMonitorController(
 		"VMWareVSphereDriverServiceMonitorController",
 		c.apiClients.DynamicClient,
@@ -324,3 +331,71 @@ func getOperatorSyncState(operatorClient v1helpers.OperatorClientWithFinalizers)
 	}
 	return opSpec.ManagementState
 }
+
+// setMaxVolumesPerNodeEnvVar sets the MAX_VOLUMES_PER_NODE environment variable
+// in container specifications based on ClusterCSIDriver configuration.
+func setMaxVolumesPerNodeEnvVar(containers []v1.Container, clusterCSIDriverLister operatorlistersv1.ClusterCSIDriverLister, featureGate featuregates.FeatureGate) ([]v1.Container, error) {
+	// Get ClusterCSIDriver object
+	clusterCSIDriver, err := clusterCSIDriverLister.Get(utils.VSphereDriverName)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get ClusterCSIDriver: %v", err)
+	}
+
+	// Get the maximum volume limit
+	maxVolumesPerNode := utils.GetMaxVolumesPerNode(clusterCSIDriver)
+
+	// Set the environment variable in all containers
+	for i := range containers {
+		container := &containers[i]
+
+		// Find and update existing MAX_VOLUMES_PER_NODE env var if it exists
+		envVarFound := false
+		for j := range container.Env {
+			if container.Env[j].Name == "MAX_VOLUMES_PER_NODE" {
+				container.Env[j].Value = strconv.FormatInt(int64(maxVolumesPerNode), 10)
+				envVarFound = true
+				break
+			}
+		}
+
+		// If not found, append it
+		if !envVarFound {
+			container.Env = append(container.Env, v1.EnvVar{
+				Name:  "MAX_VOLUMES_PER_NODE",
+				Value: strconv.FormatInt(int64(maxVolumesPerNode), 10),
+			})
+		}
+	}
+
+	return containers, nil
+}
+
+// WithMaxVolumesPerNodeDaemonSetHook sets the MAX_VOLUMES_PER_NODE environment variable in the DaemonSet container specifications.
+func WithMaxVolumesPerNodeDaemonSetHook(clusterCSIDriverLister operatorlistersv1.ClusterCSIDriverLister, featureGate featuregates.FeatureGate) csidrivernodeservicecontroller.DaemonSetHookFunc {
+	return func(opSpec *operatorapi.OperatorSpec, ds *appsv1.DaemonSet) error {
+		if !featureGate.Enabled(features.FeatureGateVSphereConfigurableMaxAllowedBlockVolumesPerNode) {
+			return nil
+		}
+		containers, err := setMaxVolumesPerNodeEnvVar(ds.Spec.Template.Spec.Containers, clusterCSIDriverLister, featureGate)
+		if err != nil {
+			return err
+		}
+		ds.Spec.Template.Spec.Containers = containers
+		return nil
+	}
+}
+
+// WithMaxVolumesPerNodeDeploymentHook sets the MAX_VOLUMES_PER_NODE environment variable in the Deployment container specifications.
+func WithMaxVolumesPerNodeDeploymentHook(clusterCSIDriverLister operatorlistersv1.ClusterCSIDriverLister, featureGate featuregates.FeatureGate) deploymentcontroller.DeploymentHookFunc {
+	return func(opSpec *operatorapi.OperatorSpec, deployment *appsv1.Deployment) error {
+		if !featureGate.Enabled(features.FeatureGateVSphereConfigurableMaxAllowedBlockVolumesPerNode) {
+			return nil
+		}
+		containers, err := setMaxVolumesPerNodeEnvVar(deployment.Spec.Template.Spec.Containers, clusterCSIDriverLister, featureGate)
+		if err != nil {
+			return err
+		}
+		deployment.Spec.Template.Spec.Containers = containers
+		return nil
+	}
+}