GeometryPath code is unnecessarily duplicated for MovingPathPoints

[chrisdembia]

The code in GeometryPath::addInEquivalentForces is unnecessarily duplicated, now that getLocation() takes a state even for non-moving points (see here):

            // add in the tension point forces to body forces
            if (mppo) {// moving path point location is a function of the state
                // transform of the frame of the point to the base mobilized body
                auto X_BF = mppo->getParentFrame().findTransformInBaseFrame();
                bo->applyForceToBodyPoint(s, X_BF*mppo->getLocation(s), force,
                    bodyForces);
            }
            else {
                // transform of the frame of the point to the base mobilized body
                auto X_BF = start->getParentFrame().findTransformInBaseFrame();
                bo->applyForceToBodyPoint(s, X_BF*start->getLocation(s), force,
                    bodyForces);
            }

Both branches are the same.

[aseth1]

I meant to clean this up! Suprised we let that slip through the review. More importantly the dynamic_casts are no longer necessary, which should speed things up too.

[tkuchida]

Suprised we let that slip through the review.

Sorry, I'm partly to blame. In my defense, this code was added in #990 (1,412 lines changed, 62 PR comments).