Filtering exposes incorrect time range to user

[tkuchida]

Running an Analysis with filtered kinematics produces an internal time vector that may be confusing to users. For example, here is the output (which gets displayed in the GUI Messages Window) when running an Analysis:

Preparing to run AnalyzeTool.
AbstractTool arm26 loading model 'arm26.osim'
Updating Model file from 20303 to latest format...
Loaded model arm26 from file arm26.osim
No external loads will be applied (external loads file not specified).

Loading coordinates from file arm26_InverseKinematics.mot.
Storage: file=arm26_InverseKinematics.mot (nr=121 nc=3)

Low-pass filtering coordinates data with a cutoff frequency of 6...

Number of columns does not match in formStateStorage. Found 4 Expected  16.
Found 241 state vectors with time stamps ranging from -0.5 to 1.5.
Executing the analyses from -2e-07 to 0.999999...
Printing results of investigation arm26 to Results-Analyze-002.

The line Found 241 state vectors with time stamps ranging from -0.5 to 1.5. is confusing because the file contains 121 rows with time stamps ranging from 0 to 1.

Also:

• The line Number of columns does not match in formStateStorage. Found 4 Expected 16. is unhelpful because the user doesn't know what "formStateStorage" means and the number of columns in the provided file is 3 (not 4).
• The line Executing the analyses from -2e-07 to 0.999999... is confusing because the specified time range was 0 to 1.

[chrisdembia]

The line Found 241 state vectors with time stamps ranging from -0.5 to 1.5.

I think this is caused by the padding that happens before filtering.

[tkuchida]

I think this is caused by the padding that happens before filtering.

I think so, too. I recommend either removing the message or, if the developer thinks it's important for the user to see this information, then they should be given enough context to understand the message (e.g., "Padding data with zeros before applying forward/backward filter...").

[aseth1]

I think the three lines prior to the last line of Printing results of ... can be removed from AnalyzeTool. My guess is that they were useful for debugging and were left in place. I don't think they were intended for user consumption.