Can't change output model file name when constructing ScaleTool systematically with API

[carmichaelong]

ScaleTool has a ModelScaler and MarkerPlacer associated with it. ModelScaler and MarkerPlacer each has methods to set the output model file from each step. However, both ScaleTool::getModelScaler() and ScaleTool::getMarkerPlacer() return const objects, so the setOutputModelFileName() functions won't change anything.

@aymanhab I'm thinking of just adding updModelScaler and updMarkerPlacer methods to ScaleTool so that these can be changed. Let me know if you think that makes sense or if there are issues that I'm missing with doing this.

[aymanhab]

@carmichaelong We need some context, for the following reasons:

• The difference between get and upd is exclusively for const correctness in C++ (you can test from Matlab/Python before making any actual interface changes).
• The pattern of defining upd methods typically includes invalidating member variables that maybe changed by the call, would that apply here (to serve C++ clients)?
• Since these objects are properties, there's likely a public non-const accessor already, I can check if you haven't done so already.

Let me know what you find out. Thanks

[carmichaelong]

From dev meeting: ScaleTool uses the old properties system. Will patch with upd methods so that the underlying MarkerPlacer and ModelScaler can be changed systematically