Bump Ruby min to 3.2 and update CI

* Update GitHub Actions matrix ruby-version to ["3.2", "3.3", "3.4"]
* Run RuboCop and upload Codecov only when matrix.ruby-version == '3.4'
* Set AllCops TargetRubyVersion to 3.2 and disable SuggestExtensions
* Add AllCops Exclude patterns for vendor/**, spec/fixtures/**, and bin/**
* Enable Style/StringLiterals and enforce single_quotes
* Enable Style/FrozenStringLiteralComment and enforce always
* Add Layout/LineLength with Max 120 and allow long comment lines
* Exclude spec/**/* and **/*.gemspec from Metrics/BlockLength
* Lower Metrics/MethodLength Max to 15 and exclude spec/**/*
* Disable Style/AsciiComments
* Add frozen_string_literal magic comment to Gemfile and add rubocop-rake dependency
* Replace gemspec description with a multiline heredoc description
* Bump gemspec required_ruby_version to '>= 3.2.0'
* Define SCHEME_PATTERN in Normalizer without calling .freeze
* Define IPV4_REGEX and IPV6_REGEX in Validators without calling .freeze
* Reformat multiple spec expectations to use multiline parentheses for eq(...) comparisons

Author: jordanhudgens

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby-version: ["3.0", "3.1", "3.2", "3.3"]
+        ruby-version: ["3.2", "3.3", "3.4"]
 
     steps:
       - uses: actions/checkout@v4
@@ -32,11 +32,11 @@ jobs:
 
       - name: Run RuboCop
         run: bundle exec rubocop
-        if: matrix.ruby-version == '3.3'
+        if: matrix.ruby-version == '3.4'
 
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v4
-        if: matrix.ruby-version == '3.3'
+        if: matrix.ruby-version == '3.4'
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           fail_ci_if_error: false

.rubocop.yml

@@ -1,20 +1,40 @@
 AllCops:
+  # Should match your gemspec's required_ruby_version minimum
+  TargetRubyVersion: 3.2
   NewCops: enable
-  TargetRubyVersion: 3.0.0
+  SuggestExtensions: false
   Exclude:
-    - "bin/**/*"
+    - "vendor/**/*"
+    - "spec/fixtures/**/*"
     - "tmp/**/*"
+    - "bin/**/*"
+
+# Customize your style preferences here
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: single_quotes
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: always
 
-require:
-  - rubocop-performance
-  - rubocop-rspec
+Layout/LineLength:
+  Max: 120
+  AllowedPatterns: ['\A#'] # Allow long comment lines
 
 Metrics/BlockLength:
   Exclude:
-    - "spec/**/*.rb"
+    - "spec/**/*"
+    - "**/*.gemspec"
 
 Metrics/MethodLength:
-  Max: 25
+  Max: 15
+  Exclude:
+    - "spec/**/*"
 
+# Disable some overly strict cops for gems
 Style/Documentation:
   Enabled: false
+
+Style/AsciiComments:
+  Enabled: false

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 gemspec
@@ -7,5 +9,6 @@ group :development, :test do
   gem 'rspec', '~> 3.12'
   gem 'rubocop', '~> 1.50', require: false
   gem 'rubocop-performance', '~> 1.18', require: false
+  gem 'rubocop-rake', '~> 0.7.1'
   gem 'rubocop-rspec', '~> 2.20', require: false
 end

Gemfile.lock

@@ -35,7 +35,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-support (3.13.6)
-    rubocop (1.81.6)
+    rubocop (1.81.7)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -59,6 +59,9 @@ GEM
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
     rubocop-rspec (2.31.0)
       rubocop (~> 1.40)
       rubocop-capybara (~> 2.17)
@@ -81,6 +84,7 @@ DEPENDENCIES
   rspec (~> 3.12)
   rubocop (~> 1.50)
   rubocop-performance (~> 1.18)
+  rubocop-rake (~> 0.7.1)
   rubocop-rspec (~> 2.20)
 
 BUNDLED WITH

domain_extractor.gemspec

@@ -20,7 +20,11 @@ Gem::Specification.new do |spec|
     .rubocop.yml
   ]
 
-  spec.description = 'DomainExtractor is a high-performance url parser and domain parser for Ruby. It delivers precise domain extraction, query parameter parsing, url normalization, and multi-part tld parsing via public_suffix for web scraping and analytics workflows.'
+  spec.description = <<~DESC.strip
+    DomainExtractor is a high-performance url parser and domain parser for Ruby. It delivers precise
+    domain extraction, query parameter parsing, url normalization, and multi-part tld parsing via
+    public_suffix for web scraping and analytics workflows.
+  DESC
   spec.email = 'dev@opensite.ai'
   spec.homepage = 'https://github.com/opensite-ai/domain_extractor'
   spec.license = 'MIT'
@@ -37,7 +41,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'public_suffix', '~> 6.0'
 
-  spec.required_ruby_version = '>= 3.0.10'
+  spec.required_ruby_version = '>= 3.2.0'
   spec.require_paths = ['lib']
   spec.extra_rdoc_files = ['README.md', 'LICENSE.txt', 'CHANGELOG.md']
   spec.rdoc_options = [

lib/domain_extractor/normalizer.rb

@@ -4,7 +4,7 @@ module DomainExtractor
   # Normalizer ensures URLs include a scheme and removes extraneous whitespace
   # before passing them into the URI parser.
   module Normalizer
-    SCHEME_PATTERN = %r{\A[A-Za-z][A-Za-z0-9+\-.]*://}.freeze
+    SCHEME_PATTERN = %r{\A[A-Za-z][A-Za-z0-9+\-.]*://}
 
     module_function
 

lib/domain_extractor/validators.rb

@@ -4,8 +4,8 @@ module DomainExtractor
   # Validators hosts fast checks for excluding unsupported hostnames (e.g. IP addresses).
   module Validators
     IPV4_SEGMENT = '(?:25[0-5]|2[0-4]\d|1\d{2}|[1-9]?\d)'
-    IPV4_REGEX = /\A#{IPV4_SEGMENT}(?:\.#{IPV4_SEGMENT}){3}\z/.freeze
-    IPV6_REGEX = /\A\[?[0-9a-fA-F:]+\]?\z/.freeze
+    IPV4_REGEX = /\A#{IPV4_SEGMENT}(?:\.#{IPV4_SEGMENT}){3}\z/
+    IPV6_REGEX = /\A\[?[0-9a-fA-F:]+\]?\z/
 
     module_function
 

spec/domain_extractor_spec.rb

@@ -87,11 +87,11 @@
       it 'extracts multiple query parameters' do
         result = described_class.parse('https://example.com/page?foo=bar&baz=qux&id=123')
 
-        expect(result[:query_params]).to eq({
+        expect(result[:query_params]).to eq(
           'foo' => 'bar',
           'baz' => 'qux',
           'id' => '123'
-        })
+        )
       end
 
       it 'handles URLs with path and multiple query parameters' do
@@ -100,10 +100,10 @@
         expect(result[:subdomain]).to eq('api')
         expect(result[:root_domain]).to eq('example.com')
         expect(result[:path]).to eq('/v1/users')
-        expect(result[:query_params]).to eq({
+        expect(result[:query_params]).to eq(
           'page' => '2',
           'limit' => '10'
-        })
+        )
       end
 
       it 'handles URLs with empty query string' do
@@ -178,11 +178,11 @@
     it 'converts multiple parameters to hash' do
       result = described_class.parse_query_params('foo=bar&baz=qux&id=123')
 
-      expect(result).to eq({
+      expect(result).to eq(
         'foo' => 'bar',
         'baz' => 'qux',
         'id' => '123'
-      })
+      )
     end
 
     it 'returns empty hash for nil query' do
@@ -212,11 +212,11 @@
     it 'handles mixed parameters with and without values' do
       result = described_class.parse_query_params('foo=bar&flag&baz=qux')
 
-      expect(result).to eq({
+      expect(result).to eq(
         'foo' => 'bar',
         'flag' => nil,
         'baz' => 'qux'
-      })
+      )
     end
 
     it 'ignores blank keys' do