Skip to content

Commit e97555b

Browse files
committed
workflows: expect macOS universal binaries from setup-python on 3.{8,9,10}
It appears setup-python's Python 3.8, 3.9, and 3.10 macOS builds are now capable of producing universal binaries. Stop using the upstream Python 3.9 and 3.10 builds and remove the test exception for 3.8. The change seems to have happened before we released any macOS wheels, so this won't affect the 3.8 release artifacts. Signed-off-by: Benjamin Gilbert <[email protected]>
1 parent 5be5565 commit e97555b

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

.github/workflows/python.yml

+1-11
Original file line numberDiff line numberDiff line change
@@ -50,16 +50,6 @@ jobs:
5050
python-version: "3.13"
5151
openslide: system
5252
sdist: sdist
53-
# Python 3.8 is too old to support universal binaries, and
54-
# setup-python's Python 3.9 and 3.10 won't build them. Use the
55-
# last upstream patch releases that ship with installers.
56-
# https://github.com/actions/setup-python/issues/439#issuecomment-1247646682
57-
- os: macos-latest
58-
python-version: "3.9"
59-
upstream-python: 3.9.13
60-
- os: macos-latest
61-
python-version: "3.10"
62-
upstream-python: 3.10.11
6353
steps:
6454
- name: Check out repo
6555
uses: actions/checkout@v4
@@ -122,7 +112,7 @@ jobs:
122112
auditwheel repair --only-plat -w dist old/*whl
123113
;;
124114
macos-*)
125-
if [ "${{ matrix.python-version }}" != 3.8 -a ! -e dist/*universal2* ]; then
115+
if [ ! -e dist/*universal2* ]; then
126116
echo "Wheel is not universal:"
127117
ls dist
128118
exit 1

0 commit comments

Comments
 (0)