Skip to content

Commit 91c4d42

Browse files
committed
upstream: remove vestige of when we supported running without privsep
OpenBSD-Commit-ID: 5342c24d2330ef5ce357c294056f72b8123122c0
1 parent 6463960 commit 91c4d42

File tree

4 files changed

+8
-43
lines changed

4 files changed

+8
-43
lines changed

auth-bsdauth.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: auth-bsdauth.c,v 1.15 2018/07/09 21:35:50 markus Exp $ */
1+
/* $OpenBSD: auth-bsdauth.c,v 1.16 2026/02/06 01:24:36 djm Exp $ */
22
/*
33
* Copyright (c) 2001 Markus Friedl. All rights reserved.
44
*
@@ -125,14 +125,6 @@ bsdauth_free_ctx(void *ctx)
125125
}
126126
}
127127

128-
KbdintDevice bsdauth_device = {
129-
"bsdauth",
130-
bsdauth_init_ctx,
131-
bsdauth_query,
132-
bsdauth_respond,
133-
bsdauth_free_ctx
134-
};
135-
136128
KbdintDevice mm_bsdauth_device = {
137129
"bsdauth",
138130
bsdauth_init_ctx,

auth.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: auth.h,v 1.108 2024/05/17 06:42:04 jsg Exp $ */
1+
/* $OpenBSD: auth.h,v 1.109 2026/02/06 01:24:36 djm Exp $ */
22

33
/*
44
* Copyright (c) 2000 Markus Friedl. All rights reserved.
@@ -182,8 +182,6 @@ int auth2_update_methods_lists(Authctxt *, const char *, const char *);
182182
int auth2_setup_methods_lists(Authctxt *);
183183
int auth2_method_allowed(Authctxt *, const char *, const char *);
184184

185-
void privsep_challenge_enable(void);
186-
187185
int auth2_challenge(struct ssh *, char *);
188186
void auth2_challenge_stop(struct ssh *);
189187
int bsdauth_query(void *, char **, char **, u_int *, char ***, u_int **);

auth2-chall.c

Lines changed: 5 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: auth2-chall.c,v 1.57 2025/10/02 08:38:43 dtucker Exp $ */
1+
/* $OpenBSD: auth2-chall.c,v 1.58 2026/02/06 01:24:36 djm Exp $ */
22
/*
33
* Copyright (c) 2001 Markus Friedl. All rights reserved.
44
* Copyright (c) 2001 Per Allansson. All rights reserved.
@@ -54,19 +54,19 @@ static int send_userauth_info_request(struct ssh *);
5454
static int input_userauth_info_response(int, u_int32_t, struct ssh *);
5555

5656
#ifdef BSD_AUTH
57-
extern KbdintDevice bsdauth_device;
57+
extern KbdintDevice mm_bsdauth_device;
5858
#else
5959
#ifdef USE_PAM
60-
extern KbdintDevice sshpam_device;
60+
extern KbdintDevice mm_sshpam_device;
6161
#endif
6262
#endif
6363

6464
KbdintDevice *devices[] = {
6565
#ifdef BSD_AUTH
66-
&bsdauth_device,
66+
&mm_bsdauth_device,
6767
#else
6868
#ifdef USE_PAM
69-
&sshpam_device,
69+
&mm_sshpam_device,
7070
#endif
7171
#endif
7272
NULL
@@ -362,25 +362,3 @@ input_userauth_info_response(int type, u_int32_t seq, struct ssh *ssh)
362362
devicename);
363363
return 0;
364364
}
365-
366-
void
367-
privsep_challenge_enable(void)
368-
{
369-
#if defined(BSD_AUTH) || defined(USE_PAM)
370-
int n = 0;
371-
#endif
372-
#ifdef BSD_AUTH
373-
extern KbdintDevice mm_bsdauth_device;
374-
#endif
375-
#ifdef USE_PAM
376-
extern KbdintDevice mm_sshpam_device;
377-
#endif
378-
379-
#ifdef BSD_AUTH
380-
devices[n++] = &mm_bsdauth_device;
381-
#else
382-
#ifdef USE_PAM
383-
devices[n++] = &mm_sshpam_device;
384-
#endif
385-
#endif
386-
}

sshd-auth.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* $OpenBSD: sshd-auth.c,v 1.10 2025/11/13 10:35:14 dtucker Exp $ */
1+
/* $OpenBSD: sshd-auth.c,v 1.11 2026/02/06 01:24:36 djm Exp $ */
22
/*
33
* SSH2 implementation:
44
* Privilege Separation:
@@ -750,9 +750,6 @@ main(int ac, char **av)
750750
fatal("sshbuf_new loginmsg failed");
751751
auth_debug_reset();
752752

753-
/* Enable challenge-response authentication for privilege separation */
754-
privsep_challenge_enable();
755-
756753
#ifdef GSSAPI
757754
/* Cache supported mechanism OIDs for later use */
758755
ssh_gssapi_prepare_supported_oids();

0 commit comments

Comments
 (0)