Skip to content

Commit a86afef

Browse files
Merge pull request #483 from openshift-cherrypick-robot/cherry-pick-474-to-18.0.0-proposed
[18.0.0-proposed] Change how MetricStorage is copied in telemetry
2 parents 2e89e59 + a768946 commit a86afef

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

controllers/telemetry_controller.go

+1-16
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import (
3737
ceilometer "github.com/openstack-k8s-operators/telemetry-operator/pkg/ceilometer"
3838
logging "github.com/openstack-k8s-operators/telemetry-operator/pkg/logging"
3939
utils "github.com/openstack-k8s-operators/telemetry-operator/pkg/utils"
40-
obov1 "github.com/rhobs/observability-operator/pkg/apis/monitoring/v1alpha1"
4140
)
4241

4342
// TelemetryReconciler reconciles a Telemetry object
@@ -406,21 +405,7 @@ func (r TelemetryReconciler) reconcileMetricStorage(ctx context.Context, instanc
406405

407406
helper.GetLogger().Info("Reconciling MetricStorage", metricStorageNamespaceLabel, instance.Namespace, metricStorageNameLabel, telemetryv1.DefaultServiceName)
408407
op, err := controllerutil.CreateOrPatch(ctx, helper.GetClient(), metricStorageInstance, func() error {
409-
if instance.Spec.MetricStorage.MetricStorageSpec.CustomMonitoringStack != nil {
410-
metricStorageInstance.Spec.CustomMonitoringStack = &obov1.MonitoringStackSpec{}
411-
instance.Spec.MetricStorage.MetricStorageSpec.CustomMonitoringStack.DeepCopyInto(metricStorageInstance.Spec.CustomMonitoringStack)
412-
} else {
413-
metricStorageInstance.Spec.CustomMonitoringStack = nil
414-
}
415-
if instance.Spec.MetricStorage.MetricStorageSpec.MonitoringStack != nil {
416-
metricStorageInstance.Spec.MonitoringStack = &telemetryv1.MonitoringStack{}
417-
instance.Spec.MetricStorage.MetricStorageSpec.MonitoringStack.DeepCopyInto(metricStorageInstance.Spec.MonitoringStack)
418-
} else {
419-
metricStorageInstance.Spec.MonitoringStack = nil
420-
}
421-
instance.Spec.MetricStorage.MetricStorageSpec.PrometheusTLS.DeepCopyInto(&metricStorageInstance.Spec.PrometheusTLS)
422-
// TODO: Uncomment this line when implementing TLS for Alertmanager
423-
//instance.Spec.MetricStorage.MetricStorageSpec.AlertmanagerTLS.DeepCopyInto(&metricStorageInstance.Spec.AlertmanagerTLS)
408+
instance.Spec.MetricStorage.MetricStorageSpec.DeepCopyInto(&metricStorageInstance.Spec)
424409

425410
err := controllerutil.SetControllerReference(helper.GetBeforeObject(), metricStorageInstance, helper.GetScheme())
426411
if err != nil {

0 commit comments

Comments
 (0)