scrapers: replace deprecated Logger.warn with .warning (#5677)

Logger.warn was deprecated back in Python 3.3 in favour of .warning,
and the bare warn shim warns on import in 3.13. Sweep the 15 call
sites across MA, NY, OR, and utils.

Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>

Author: c-tonneslan

scrapers/ma/votes.py

@@ -162,7 +162,7 @@ def process_page(self):
         # If they disagree on number of matches, the scraper will not get
         # the data correctly so emit a warning and skip this pdf.
         if not (len(votes_mt) == len(votes_s) == len(votes_id)):
-            self.logger.warn(
+            self.logger.warning(
                 f"\nCould not accurately parse votes for "
                 f"{self.source.url}\n"
                 f"len(votes_mt):{len(votes_mt)}\n"
@@ -184,7 +184,7 @@ def process_page(self):
     def parse_match(self, match, index):
         bill_id = self.get_bill_id(index)
         if not bill_id:
-            self.logger.warn(
+            self.logger.warning(
                 f"No valid bill id found preceding vote lines in {self.source.url}"
             )
             return {}
@@ -224,7 +224,7 @@ def parse_match(self, match, index):
         if motion_text:
             motion_text = motion_text.group(1)
         else:
-            self.logger.warn(
+            self.logger.warning(
                 f"No valid motion text found preceding vote lines in {self.source}"
             )
             return
@@ -239,7 +239,7 @@ def parse_match(self, match, index):
                 break
 
         if not vote_classification:
-            self.logger.warn(
+            self.logger.warning(
                 f"""
                 No vote_classification from {single_line_motion}" in journal at {self.source.url}
                 """
@@ -293,7 +293,7 @@ def parse_match(self, match, index):
         yea_mismatch = first_total_yea != total_yea
         nay_mismatch = first_total_nay != total_nay
         if yea_mismatch or nay_mismatch:
-            self.logger.warn(
+            self.logger.warning(
                 f"Cannot accurately parse to determine margins for vote {index + 1} in {self.source.url}"
             )
             return {}
@@ -304,7 +304,7 @@ def parse_match(self, match, index):
         for miscount in yea_matches_miscount, nay_matches_miscount:
             # Allows for minor miscount in cases of PDF formatting issues
             if abs(miscount) > determinative_margin:
-                self.logger.warn(
+                self.logger.warning(
                     f"Cannot accurately parse to determine margins for vote {index + 1} in {self.source.url}"
                 )
                 return {}
@@ -346,7 +346,7 @@ def get_bill_id(self, index):
             chamber, number = bill_id_match[-1]
             self.bill_id = f"{chamber[0]} {number}"
         if not self.bill_id:
-            self.logger.warn(
+            self.logger.warning(
                 f"No preceding bill id for vote {index + 1} in {self.source.url}"
             )
         return self.bill_id
@@ -516,7 +516,7 @@ def process_page(self):
         for vote in vote_text:
             vote_parser = HouseVoteRecordParser(vote, session=self.session)
             if (warning := vote_parser.get_warning()) is not None:
-                self.logger.warn(warning)
+                self.logger.warning(warning)
             else:
                 vote_parser.error_if_invalid()
                 vote_event = vote_parser.createVoteEvent()

scrapers/ny/bills.py

@@ -51,7 +51,7 @@ def _parse_bill_details(self, bill):
         title = bill["title"].strip()
 
         if not title:
-            self.logger.warn("Bill missing title.")
+            self.logger.warning("Bill missing title.")
             return
 
         # Determine the chamber the bill originated from.
@@ -61,7 +61,7 @@ def _parse_bill_details(self, bill):
             bill_chamber = "lower"
         else:
             warning = "Could not identify chamber for {}."
-            self.logger.warn(warning).format(bill_id)
+            self.logger.warning(warning).format(bill_id)
 
         senate_url = (
             "http://www.nysenate.gov/legislation/bills/{bill_session}/" "{bill_id}"

scrapers/or/bills.py

@@ -88,7 +88,7 @@ def scrape_bills(self, session):
                     try:
                         legislator = legislators[legislator_code]
                     except KeyError:
-                        logger.warn(
+                        logger.warning(
                             "Legislator {} not found in session {}".format(
                                 legislator_code, session
                             )
@@ -118,7 +118,7 @@ def scrape_bills(self, session):
                         media_type="application/pdf",
                     )
                 except ValueError:
-                    logger.warn("Duplicate link found for {}".format(document_url))
+                    logger.warning("Duplicate link found for {}".format(document_url))
 
             for agenda_item in measure["CommitteeAgendaItems"]:
                 for document in agenda_item["CommitteeProposedAmendments"]:

scrapers/or/committees.py

@@ -41,7 +41,7 @@ def scrape_committees(self, session):
                 try:
                     member_name = legislators[member["LegislatorCode"]]
                 except KeyError:
-                    logger.warn(
+                    logger.warning(
                         "Legislator {} not found in session {}".format(
                             member["LegislatorCode"], session_key
                         )

scrapers/or/votes.py

@@ -150,7 +150,7 @@ def add_individual_votes(self, vote, vote_call, vote_type):
             try:
                 voter_name = self.legislators[voter["VoteName"]]
             except KeyError:
-                logger.warn(
+                logger.warning(
                     "Legislator {} not found in session {}".format(
                         voter["VoteName"], self.session_key
                     )

scrapers/utils/votes.py

@@ -22,4 +22,4 @@ def check_counts(vote, raise_error=False):
             if raise_error:
                 raise ValueError(msg)
             else:
-                logger.warn(msg)
+                logger.warning(msg)