Skip to content

Commit b356548

Browse files
committed
Updated formatting code
Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
1 parent 26603f2 commit b356548

File tree

4 files changed

+38
-19
lines changed

4 files changed

+38
-19
lines changed

packages/api/src/service/import.ts

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,11 @@ type ImportOptions = {
3232

3333
function createProvider(
3434
providerName: string,
35-
config: Record<string, unknown>,
35+
_config: Record<string, unknown>,
3636
): ImportProvider {
3737
switch (providerName) {
3838
case "betterstack":
3939
return createBetterstackProvider();
40-
case "statuspage":
4140
default:
4241
return createStatuspageProvider();
4342
}
@@ -808,8 +807,21 @@ async function writeMonitorsPhase(
808807
.insert(monitor)
809808
.values({
810809
workspaceId,
811-
jobType: data.jobType as "http" | "tcp" | "imcp" | "udp" | "dns" | "ssl",
812-
periodicity: data.periodicity as "30s" | "1m" | "5m" | "10m" | "30m" | "1h" | "other",
810+
jobType: data.jobType as
811+
| "http"
812+
| "tcp"
813+
| "imcp"
814+
| "udp"
815+
| "dns"
816+
| "ssl",
817+
periodicity: data.periodicity as
818+
| "30s"
819+
| "1m"
820+
| "5m"
821+
| "10m"
822+
| "30m"
823+
| "1h"
824+
| "other",
813825
status: "active",
814826
active: data.active,
815827
regions: data.regions,
@@ -818,7 +830,16 @@ async function writeMonitorsPhase(
818830
description: data.description,
819831
headers: data.headers,
820832
body: data.body,
821-
method: data.method as "GET" | "POST" | "HEAD" | "PUT" | "PATCH" | "DELETE" | "TRACE" | "CONNECT" | "OPTIONS",
833+
method: data.method as
834+
| "GET"
835+
| "POST"
836+
| "HEAD"
837+
| "PUT"
838+
| "PATCH"
839+
| "DELETE"
840+
| "TRACE"
841+
| "CONNECT"
842+
| "OPTIONS",
822843
timeout: data.timeout,
823844
})
824845
.returning({ id: monitor.id });

packages/importers/src/providers/betterstack/api-types.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,7 @@ export const BetterstackStatusPageSchema = z.object({
6666
}),
6767
});
6868

69-
export type BetterstackStatusPage = z.infer<
70-
typeof BetterstackStatusPageSchema
71-
>;
69+
export type BetterstackStatusPage = z.infer<typeof BetterstackStatusPageSchema>;
7270

7371
export const BetterstackStatusPageSectionSchema = z.object({
7472
id: z.string(),

packages/importers/src/providers/betterstack/client.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
1-
import { z } from "zod";
1+
import type { z } from "zod";
22
import {
33
type BetterstackIncident,
44
BetterstackIncidentSchema,
55
type BetterstackMonitor,
6-
BetterstackMonitorSchema,
76
type BetterstackMonitorGroup,
87
BetterstackMonitorGroupSchema,
8+
BetterstackMonitorSchema,
99
type BetterstackStatusPage,
1010
BetterstackStatusPageSchema,
1111
type BetterstackStatusPageSection,

packages/importers/src/providers/betterstack/provider.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
2-
import { createBetterstackProvider } from "./provider";
32
import {
43
MOCK_INCIDENTS,
54
MOCK_MONITORS,
65
MOCK_MONITOR_GROUPS,
76
MOCK_STATUS_PAGES,
87
MOCK_STATUS_PAGE_SECTIONS,
98
} from "./fixtures";
9+
import { createBetterstackProvider } from "./provider";
1010

1111
const originalFetch = globalThis.fetch;
1212

@@ -112,8 +112,8 @@ describe("BetterstackProvider", () => {
112112

113113
const monitorsPhase = summary.phases.find((p) => p.phase === "monitors");
114114
expect(monitorsPhase).toBeDefined();
115-
expect(monitorsPhase!.resources).toHaveLength(3);
116-
expect(monitorsPhase!.resources[0].name).toBe("API Health Check");
115+
expect(monitorsPhase?.resources).toHaveLength(3);
116+
expect(monitorsPhase?.resources[0].name).toBe("API Health Check");
117117
});
118118

119119
test("page phase maps status page correctly", async () => {
@@ -125,8 +125,8 @@ describe("BetterstackProvider", () => {
125125

126126
const pagePhase = summary.phases.find((p) => p.phase === "page");
127127
expect(pagePhase).toBeDefined();
128-
expect(pagePhase!.resources).toHaveLength(1);
129-
expect(pagePhase!.resources[0].name).toBe("Acme Corp");
128+
expect(pagePhase?.resources).toHaveLength(1);
129+
expect(pagePhase?.resources[0].name).toBe("Acme Corp");
130130
});
131131

132132
test("incidents phase maps all incidents", async () => {
@@ -138,7 +138,7 @@ describe("BetterstackProvider", () => {
138138

139139
const incidentsPhase = summary.phases.find((p) => p.phase === "incidents");
140140
expect(incidentsPhase).toBeDefined();
141-
expect(incidentsPhase!.resources).toHaveLength(3);
141+
expect(incidentsPhase?.resources).toHaveLength(3);
142142
});
143143

144144
test("filters by betterstackStatusPageId", async () => {
@@ -155,7 +155,7 @@ describe("BetterstackProvider", () => {
155155

156156
const monitorsPhase = summary.phases.find((p) => p.phase === "monitors");
157157
expect(monitorsPhase).toBeDefined();
158-
expect(monitorsPhase!.resources).toHaveLength(3);
158+
expect(monitorsPhase?.resources).toHaveLength(3);
159159
});
160160

161161
test("monitor resources include sourceMonitorGroupId", async () => {
@@ -166,13 +166,13 @@ describe("BetterstackProvider", () => {
166166
});
167167

168168
const monitorsPhase = summary.phases.find((p) => p.phase === "monitors");
169-
const firstMonitor = monitorsPhase!.resources[0].data as Record<
169+
const firstMonitor = monitorsPhase?.resources[0].data as Record<
170170
string,
171171
unknown
172172
>;
173173
expect(firstMonitor.sourceMonitorGroupId).toBe("bs_group_001");
174174

175-
const thirdMonitor = monitorsPhase!.resources[2].data as Record<
175+
const thirdMonitor = monitorsPhase?.resources[2].data as Record<
176176
string,
177177
unknown
178178
>;

0 commit comments

Comments
 (0)