fix: comments

Author: mxkaske

apps/dashboard/src/components/forms/components/form-import.tsx

@@ -273,8 +273,8 @@ export function FormImport({
                           <Input placeholder="e.g. clx1abc2def3" {...field} />
                         </FormControl>
                         <FormDescription>
-                          Import a specific page. Leave empty to import the
-                          first page.
+                          Import a specific page. Leave empty to import all
+                          pages.
                         </FormDescription>
                       </FormItem>
                     )}

packages/importers/src/providers/instatus/client.test.ts

@@ -104,12 +104,11 @@ describe("InstatusClient", () => {
   });
 
   test("sends correct Bearer auth header", async () => {
-    mockFetch(MOCK_PAGES);
+    mockFetchPaginated(MOCK_PAGES);
     await client.getPages();
     const fetchMock = globalThis.fetch as unknown as ReturnType<typeof mock>;
-    expect(fetchMock).toHaveBeenCalledTimes(1);
     const [url, options] = fetchMock.mock.calls[0] as [string, RequestInit];
-    expect(url).toBe("https://api.instatus.com/v2/pages");
+    expect(url).toBe("https://api.instatus.com/v2/pages?page=1&per_page=100");
     expect((options.headers as Record<string, string>).Authorization).toBe(
       "Bearer test-api-key",
     );

packages/importers/src/providers/instatus/client.ts

@@ -65,7 +65,7 @@ export function createInstatusClient(
   }
 
   return {
-    getPages: () => request("/v2/pages", z.array(InstatusPageSchema)),
+    getPages: () => requestAllPages("/v2/pages", InstatusPageSchema),
     getPage: (pageId) => request(`/v2/${pageId}`, InstatusPageSchema),
     getComponents: (pageId) =>
       requestAllPages(`/v2/${pageId}/components`, InstatusComponentSchema),

packages/importers/src/providers/instatus/mapper.ts

@@ -164,7 +164,10 @@ export function mapMaintenanceToMaintenance(
 
   const from = new Date(m.start);
   const duration = m.duration ?? 0;
-  const to = duration > 0 ? new Date(from.getTime() + duration * 60_000) : from;
+  const to =
+    duration > 0
+      ? new Date(from.getTime() + duration * 60_000)
+      : new Date(from);
 
   return {
     title: m.name,

packages/importers/src/providers/instatus/provider.test.ts

@@ -21,8 +21,11 @@ function createMockFetch(options?: { failAuth?: boolean }) {
       );
     }
 
-    if (url.match(/\/v2\/pages$/)) {
-      return Promise.resolve(Response.json(MOCK_PAGES));
+    if (url.match(/\/v2\/pages(\?|$)/)) {
+      const pageParam = new URL(url).searchParams.get("page");
+      return Promise.resolve(
+        Response.json(pageParam === "1" || !pageParam ? MOCK_PAGES : []),
+      );
     }
     if (url.match(/\/v2\/[^/]+\/components(\?|$)/)) {
       const pageParam = new URL(url).searchParams.get("page");
@@ -145,25 +148,15 @@ describe("InstatusImportProvider", () => {
       matching.phases.find((p) => p.phase === name);
     expect(findPhase("page")?.resources).toHaveLength(1);
 
-    // Filter by non-existent page ID — should return empty phases
+    // Filter by non-existent page ID — should return failed with error
     const nonMatching = await provider.run({
       apiKey: "test-key",
       workspaceId: 1,
       dryRun: true,
       instatusPageId: "nonexistent",
     });
-    expect(nonMatching.phases).toHaveLength(0);
-  });
-
-  it("reports skipped non-email subscribers", async () => {
-    const provider = createInstatusProvider();
-    const summary = await provider.run({
-      apiKey: "test-key",
-      workspaceId: 1,
-      dryRun: true,
-    });
-
-    expect(summary.errors).toHaveLength(1);
-    expect(summary.errors[0]).toContain("3 non-email subscribers were skipped");
+    expect(nonMatching.status).toBe("failed");
+    expect(nonMatching.errors).toHaveLength(1);
+    expect(nonMatching.errors[0]).toContain("nonexistent");
   });
 });

packages/importers/src/providers/instatus/provider.ts

@@ -49,10 +49,21 @@ export function createInstatusProvider(): ImportProvider<InstatusImportConfig> {
       let pages = await client.getPages();
       if (config.instatusPageId) {
         pages = pages.filter((p) => p.id === config.instatusPageId);
+        if (pages.length === 0) {
+          return {
+            provider: "instatus",
+            status: "failed",
+            startedAt: new Date(),
+            completedAt: new Date(),
+            phases: [],
+            errors: [
+              `No page found with ID "${config.instatusPageId}". Check the page ID and try again.`,
+            ],
+          };
+        }
       }
 
       let skippedSubscribers = 0;
-      const allWarnings: string[] = [];
 
       for (const pg of pages) {
         const [allComponents, incidents, maintenances, subscribers] =
@@ -63,12 +74,7 @@ export function createInstatusProvider(): ImportProvider<InstatusImportConfig> {
             client.getSubscribers(pg.id),
           ]);
 
-        const {
-          groups,
-          components,
-          warnings: partitionWarnings,
-        } = partitionComponents(allComponents);
-        allWarnings.push(...partitionWarnings);
+        const { groups, components } = partitionComponents(allComponents);
 
         // Page phase
         const mappedPage = mapPage(pg, config.workspaceId);
@@ -169,7 +175,7 @@ export function createInstatusProvider(): ImportProvider<InstatusImportConfig> {
         });
       }
 
-      const errors: string[] = [...allWarnings];
+      const errors: string[] = [];
       if (skippedSubscribers > 0) {
         errors.push(
           `Only email subscribers are supported. ${skippedSubscribers} non-email subscriber${skippedSubscribers === 1 ? " was" : "s were"} skipped.`,