Skip to content

Refactor fixthemap to remove javascript and add tests #257

Open
openstreetmap/openstreetmap-website
#5887
@gravitystorm

Description

@gravitystorm

There's a feature on the fixthemap page that means you can link to it like this:

https://www.openstreetmap.org/fixthemap?lat=47.21776092401608&lon=8.524017333984375&zoom=13

... and the note icon will then get a link to the right place on the map. This is done by javascript after the page has loaded.

But the controller has access to this information too, and it can rework it and pass it to the view, so there's no need for it to be in javascript. So let's refactor it, since building links in javascript on pageload is quite unexpected.

It could also do with a test, since third-party pages rely on it working.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions