Add validation of report parameters#7037
Open
anovak4 wants to merge 1 commit into
Open
Conversation
tomhughes
reviewed
Apr 26, 2026
tomhughes
reviewed
May 3, 2026
| session_for(target_user) | ||
|
|
||
| # Invalid id | ||
| get new_report_path(:reportable_id => target_user.id + 1, :reportable_type => "User") |
Member
There was a problem hiding this comment.
Is just incrementing the user ID a safe way of guaranteeing an invalid user? I guess it probably is so long as users are created in monotonic order.
Also we should probably test the other item types?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6970
Adds validation of the id and type parameters when creating a new report.
Previously, if you tried to report a nonexistent user or entry, you would be taken to a confusing page where you are reporting "/reports/new". Now, if the type or id are invalid, the user gets redirected to the main page and a warning popup telling the user "The item you are trying to report could not be found".
This situation is hard to run across from the typical user flow, but it's still good to protect against.