Hide note resolving without comment button for users without map changes

[deevroman]

Description

Often, newcomers don't understand the OSM note workflow and click the Resolve button in the hopes that their changes will appear on the map. After that, they can reopen the note, even repeat it again.

The situation is further aggravated by the fact that in languages ​​like Russian, the translation is close in meaning to the word "Close", and beginners confuse this button, thinking it will close the tab.

I propose not to provide the option to close a note without comment if the user has not made any edits to the map.

This is not an API-level change, because in iD, for example, you typically close notes first and then submit map changes.

There's one special case: sometimes people accidentally reactivate a note. In this case, it's better to simply let the user close the note. For these cases, a check has been added to ensure that the last comment was made by the current user.

How has this been tested?

Form for user without changesets:

For user without changesets with his comment:

For user with changesets:

E2E-tests have also been added.

About implementation

The initial button is selected on the server. An additional field can_resolve_without_comment is added to the button, which is checked on the JS side, when entering text.

[pablobm]

I feel your pain (I have clicked the wrong thing before) but I think that this may cause as much confusion, if not more, than the current situation.

For example, you say that users may "click the Resolve button in the hopes that their changes will appear on the map". In this case, checking that they have edited the map will not help. Also they may comment on the note (thus making them the last author) right before clicking to resolve.

Those are just quick examples that come to mind. Other types of confusion will be available.

I wonder if simpler changes could be more efficient here. For example:

1. Making "Comment" the main call to action, blue on white, at the flex-start, while we style "Resolve" in a way that feels more secondary (eg: blue on white) and on the flex-end, with a gap (flex space-between) in the middle.
2. Rewording the "Resolve" button to something more descriptive like "Mark resolved"
3. A bit more involved: show some sort of confirmation flow after clicking "Resolve".

[deevroman]

Also they may comment on the note

But what will the user write there? The main thing here is that the user will ask himself this question and perhaps he will simply do nothing, instead of pressing the buttons.

---

Note that the textarea currently doesn't have a placeholder. We might consider adding something useful.

[matkoniecz]

In this case, checking that they have edited the map will not help.

It will restrict ones most likely to be confused. Such users are very likely to do bogus closures compared to valid ones