API to tell if notes are allowed in a given point#7105
Open
pablobm wants to merge 3 commits into
Open
Conversation
gravitystorm
requested changes
May 21, 2026
Collaborator
There was a problem hiding this comment.
This should use resourceful naming. The controller should have one of the specified action names, the route should be resourceful, and also the url used in the API should be changed to match.
I agree that it should be a GET request, but you can't "get an allowed" - "allowed" is not a noun.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6794
Clients have a right to know if a note will be allowed in a specific point before they submit it. Let's give them a way to check.
I'm going with
GET /api/0.6/notes/allowed?lat=&lon=. I considered making it into something more generic, to provide for a future where moderation zones cover other elements. However I decided this was premature, and anything more generic can be added in a back-compatible way when the time comes.At the moment, any authenticated request will receive
200 OK. Unauthenticated requests will get403 Forbiddenif they point within a moderation zone, and200 OKotherwise.