Add query parameter to suppress display of signup UI elements#7138
Add query parameter to suppress display of signup UI elements#7138simonpoole wants to merge 1 commit into
Conversation
simonpoole
force-pushed
the
hide-account-sign-up
branch
from
ef4e3f1 to
830af5b
Compare
simonpoole
force-pushed
the
hide-account-sign-up
branch
from
6614502 to
7e20cd7
Compare
simonpoole
changed the title
simonpoole
force-pushed
the
hide-account-sign-up
branch
2 times, most recently
from
ba7235d to
e92f95b
Compare
simonpoole
force-pushed
the
hide-account-sign-up
branch
from
e92f95b to
979cb52
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
No strong feelings on this. We know that googles review is happy when there is no "visual" hint that you can sign up as that is what we've done for the last two years (see #5118 (comment)) and I kind of want to keep changes to a minimum if at all possible. The requirement is just that you can't signup from the app (not that you can't signup at all :-)) and arguably manually crafting an URL and entering it in a browser is not "in the app". |
tomhughes
left a comment
tomhughes
left a comment
There was a problem hiding this comment.
Squash the two commits together please, then I think this is good.
This adds support for a query paramater "allow_signup" that will suppress the rendering of signup UI elements during the OAuth2 authorisation flow. This is the same solution as github implements for their "webflow" OAuth2 process. Resolves openstreetmap#5118
simonpoole
force-pushed
the
hide-account-sign-up
branch
from
3011f8f to
c5ac15e
Compare
Done. |
3 participants
This adds support for a query parameter "allow_signup" that will suppress the rendering of signup UI elements during the OAuth2 authorisation flow.
This is the same solution as github implements for their "webflow" OAuth2 process.
Resolves #5118
Description
With allow_signup set to "true" or absent there are no visual changes, with allow_signup set to "false" during authorisation, the log in/sign up tabs are removed, including the similar buttons when the hamburger menu is clicked. Screenshots from authorisation with allow_signup=false.
How has this been tested?
Not at all yet ... this needs to have an integration test.