This tiny change fixes #3360 and brings an end to the most confusing debugging session I can recall. So, apparently Yahoo imagery is totally different. I didn't know. We go through the motions of initialising TileSet, and calling it every frame. But it's not doing anything. Why? Because the Yahoo API is actually doing the work. I was staring at the code, thinking "This is bizarre, I swear this code is not actually causing what I'm seeing on the screen...but what is?" Very, very trippy.

Oh yeah, about the bug. The Yahoo initialisation was hard coded to start dimmed. Now it's not.

git-svn-id: http://svn.openstreetmap.org/applications/editors/potlatch2@25522 b9d5c4c9-76e1-0310-9c85-f3177eceb1e4

Author: stevage

net/systemeD/halcyon/TileSet.as

@@ -7,6 +7,10 @@ package net.systemeD.halcyon {
 	import flash.system.LoaderContext;
 	import flash.utils.Timer;
 
+    /** This class manages the fetching of tiles for background imagery from compatible servers. When the map is scrolled,
+    * it works out which tiles are needed, and requests them. When they arrive, they are faded into display.
+    * Important note: this class is *not* used for Yahoo! imagery. That is handled through the Yahoo and YahooMap classes.
+    */
     public class TileSet extends Sprite {
 
 		public var tile_l:int;
@@ -157,9 +161,9 @@ package net.systemeD.halcyon {
 
 /* We may need something like this in the future, not sure. Trouble is if a tile doesn't get loaded on first go,
    it will never get loaded. 
-        private function checkTileLoaded(z,x,y) {
+        private function checkTileLoaded(z:int,x:int,y:int) {
             if (tiles[z+','+x+','+y]==true){
-            	trace("Didn't even start getting tile: " + z+','+x+','+y);
+                trace("Didn't even start getting tile: " + z+','+x+','+y);            	
             	requests.push([z,x,y]);
             	return; 
             }	

net/systemeD/potlatch2/Yahoo.as

@@ -21,14 +21,16 @@ package net.systemeD.potlatch2 {
 		private var inited:Boolean;
 		private var enabled:Boolean;
 
-		public function Yahoo(w:Number, h:Number, map:Map) {
+		public function Yahoo(w:Number, h:Number, map:Map, initparams:Object) {
 			super();
 			this.init(token, w, h);  
 			this.mapType="satellite";
-			this.alpha=0.5;
 			this.map=map;
 			inited=false;
 			visible=enabled=false;
+            if (initparams['background_dim'] == null || initparams['background_dim']) alpha = 0.5;
+            else alpha=1; // map.getDimming() not initialised yet. 
+
 			this.addEventListener(YahooMapEvent.MAP_INITIALIZE, initHandler);
 		}
 

potlatch2.mxml

@@ -173,7 +173,7 @@
             theMap.addEventListener(MapEvent.INITIALISED, function(e:Event):void { VectorBackgrounds.instance().init(theMap); });
 
 			theMap.backdrop=b;
-			yahoo=new Yahoo(w,h,theMap);
+			yahoo=new Yahoo(w,h,theMap, params);
 			yahoo.hide();
 			_root.addChild(yahoo);
 			_root.addChild(theMap);