Skip to content

Commit 925d15d

Browse files
committed
fix isTab in offscreen + drop redundancies
1 parent 3b5c9a6 commit 925d15d

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

src/js/msg-api.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ export let bgReadySignal;
2525
let bgReadying = !__.MV3 && new Promise(fn => (bgReadySignal = fn));
2626
/** @type {number} top document mode
2727
* -1 = top prerendered, 0 = iframe, 1 = top, 2 = top reified */
28-
export let TDM = isFrame ? 0 : !__.IS_BG && document.prerendering ? -1 : 1;
28+
export let TDM = __.ENTRY === 'offscreen' ? 1
29+
: isFrame ? 0
30+
: !__.IS_BG && document.prerendering ? -1 : 1;
2931

30-
if (!__.ENTRY || __.IS_BG) {
31-
isTab = true;
32+
if (__.ENTRY !== true) {
33+
isTab = !__.ENTRY;
3234
} else if (__.MV3) {
3335
isTab = global[__.CLIENT_DATA].tabId >= 0;
3436
} else if (new URLSearchParams(location.search).has(kSidebar)) {
@@ -47,17 +49,18 @@ export function updateTDM(value) {
4749
export async function apiSendProxy({name: path}, thisObj, args) {
4850
const localErr = new Error();
4951
const msg = {data: {method: kInvokeAPI, path, args}, TDM};
50-
for (let res, err, retry = 0; retry < 2; retry++) {
52+
for (let res, err, retry = 0; retry < (__.MV3 ? 1 : 2); !__.MV3 && retry++) {
5153
try {
5254
if (__.MV3 || FF) {
53-
res = await (FF ? browser : chrome).runtime.sendMessage(msg);
55+
res = await (__.MV3 ? chrome : browser).runtime.sendMessage(msg);
5456
} else {
5557
res = await new Promise((resolve, reject) =>
5658
chrome.runtime.sendMessage(msg, res2 =>
5759
((err = chrome.runtime.lastError)) ? reject(err) : resolve(res2)));
5860
}
5961
if (res) {
60-
bgReadying = bgReadySignal = null;
62+
if (!__.MV3)
63+
bgReadying = bgReadySignal = null;
6164
if ((err = res.error)) {
6265
err.stack += '\n' + localErr.stack;
6366
throw err;
@@ -71,9 +74,10 @@ export async function apiSendProxy({name: path}, thisObj, args) {
7174
throw e;
7275
}
7376
}
74-
if (retry) {
77+
if (!__.MV3 && retry) {
7578
throw new Error('Stylus could not connect to the background script.');
7679
}
77-
await bgReadying;
80+
if (!__.MV3)
81+
await bgReadying;
7882
}
7983
}

0 commit comments

Comments
 (0)