cleanup and add sudo set for liquidity scale max

Author: 0xcacti

pallets/admin-utils/src/lib.rs

@@ -1448,7 +1448,7 @@ pub mod pallet {
             Ok(())
         }
 
-        ///
+        /// Change liquidity scale max for a given subnet.
         ///
         /// # Arguments
         /// * `origin` - The origin of the call, which must be the root account.
@@ -1476,6 +1476,36 @@ pub mod pallet {
             );
             Ok(())
         }
+
+        ///
+        ///
+        /// # Arguments
+        /// * `origin` - The origin of the call, which must be the root account.
+        /// * `netuid` - The unique identifier for the subnet.
+        /// * `` -
+        ///
+        /// # Errors
+        /// * `BadOrigin` - If the caller is not the root account.
+        ///
+        /// # Weight
+        /// Weight is handled by the `#[pallet::weight]` attribute.
+        #[pallet::call_index(66)]
+        #[pallet::weight((0, DispatchClass::Operational, Pays::No))]
+        pub fn sudo_set_liquidity_scale_max(
+            origin: OriginFor<T>,
+            netuid: u16,
+            liquidity_scale_max: u64,
+        ) -> DispatchResult {
+            ensure_root(origin)?;
+            pallet_subtensor::LiquidityScaleMax::<T>::set(netuid, liquidity_scale_max);
+
+            log::debug!(
+                "LiquidityScaleMax( netuid: {:?}, liquidity_scale_max: {:?} )",
+                netuid,
+                liquidity_scale_max
+            );
+            Ok(())
+        }
     }
 }
 

pallets/admin-utils/src/tests/mod.rs

@@ -1711,3 +1711,55 @@ fn test_sudo_set_ema_halving() {
         assert_eq!(value_after_2, to_be_set);
     });
 }
+
+#[test]
+fn test_sudo_set_liquidity_scale_max() {
+    new_test_ext().execute_with(|| {
+        let netuid: u16 = 1;
+        let to_be_set: u64 = 1_234;
+        // install a subnet with owner = 10
+        add_network(netuid, 10);
+
+        // read the default
+        let before: u64 = pallet_subtensor::LiquidityScaleMax::<Test>::get(netuid);
+
+        // 1) wrong signed account → BadOrigin, no change
+        assert_eq!(
+            AdminUtils::sudo_set_liquidity_scale_max(
+                <<Test as Config>::RuntimeOrigin>::signed(U256::from(1)),
+                netuid,
+                to_be_set
+            ),
+            Err(DispatchError::BadOrigin)
+        );
+        assert_eq!(
+            pallet_subtensor::LiquidityScaleMax::<Test>::get(netuid),
+            before
+        );
+
+        // 2) subnet owner but not root → still BadOrigin
+        let owner = U256::from(10);
+        pallet_subtensor::SubnetOwner::<Test>::insert(netuid, owner);
+        assert_eq!(
+            AdminUtils::sudo_set_liquidity_scale_max(
+                <<Test as Config>::RuntimeOrigin>::signed(owner),
+                netuid,
+                to_be_set
+            ),
+            Err(DispatchError::BadOrigin)
+        );
+        assert_eq!(
+            pallet_subtensor::LiquidityScaleMax::<Test>::get(netuid),
+            before
+        );
+
+        // 3) root origin → Ok, value updated
+        assert_ok!(AdminUtils::sudo_set_liquidity_scale_max(
+            <<Test as Config>::RuntimeOrigin>::root(),
+            netuid,
+            to_be_set
+        ));
+        let after: u64 = pallet_subtensor::LiquidityScaleMax::<Test>::get(netuid);
+        assert_eq!(after, to_be_set);
+    });
+}

pallets/subtensor/src/tests/mock.rs

@@ -185,7 +185,7 @@ parameter_types! {
     pub const InitialDissolveNetworkScheduleDuration: u64 =  5 * 24 * 60 * 60 / 12; // Default as 5 days
     pub const InitialTaoWeight: u64 = 0; // 100% global weight.
     pub const InitialEmaPriceHalvingPeriod: u64 = 201_600_u64; // 4 weeks
-    pub const LiquidityScaleMax: u64 = 2000; // TODO: figure out what this value should be
+    pub const LiquidityScaleMax: u64 = 2000;
     pub const DurationOfStartCall: u64 =  7 * 24 * 60 * 60 / 12; // Default as 7 days
 }
 

runtime/src/lib.rs

@@ -1044,7 +1044,7 @@ parameter_types! {
     pub const InitialDissolveNetworkScheduleDuration: BlockNumber = 5 * 24 * 60 * 60 / 12; // 5 days
     pub const SubtensorInitialTaoWeight: u64 = 971_718_665_099_567_868; // 0.05267697438728329% tao weight.
     pub const InitialEmaPriceHalvingPeriod: u64 = 201_600_u64; // 4 weeks
-    pub const LiquidityScaleMax: u64 = 2000; // TODO: figure out what this should be
+    pub const LiquidityScaleMax: u64 = 2000;
     pub const DurationOfStartCall: u64 = if cfg!(feature = "fast-blocks") {
         10 // Only 10 blocks for fast blocks
     } else {