[netif] fix pbuf allocation type and task execution (#33)

gjc13 · web-flow · commit a6e1c6ad2e46 · 2020-07-14T20:37:27.000-07:00
- Fix wrong pbuf allocate type.
- Always trigger OpenThread task after calling OpenThread apis.
diff --git a/src/core/netif.cpp b/src/core/netif.cpp
@@ -302,7 +302,7 @@ static void processReceive(otMessage *aMessage, void *aContext)
 
     assert(sNetif.state == aInstance);
 
-    buffer = pbuf_alloc(PBUF_RAW, length, PBUF_POOL);
+    buffer = pbuf_alloc(PBUF_LINK, length, PBUF_POOL);
 
     VerifyOrExit(buffer != NULL, error = OT_ERROR_NO_BUFS);
 
@@ -360,14 +360,11 @@ static void processTransmit(otInstance *aInstance)
     }
 
     // Notify if more
-    if (sHeadOutput != NULL)
-    {
-        otrTaskNotifyGive();
-    }
-    else
+    if (sHeadOutput == NULL)
     {
         sLastOutput = NULL;
     }
+    otrTaskNotifyGive();
 
 exit:
     if (error != OT_ERROR_NONE)

Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ static void processReceive(otMessage aMessage, void aContext)`
`302`	`302`
`303`	`303`	`assert(sNetif.state == aInstance);`
`304`	`304`
`305`		`- buffer = pbuf_alloc(PBUF_RAW, length, PBUF_POOL);`
	`305`	`+ buffer = pbuf_alloc(PBUF_LINK, length, PBUF_POOL);`
`306`	`306`
`307`	`307`	`VerifyOrExit(buffer != NULL, error = OT_ERROR_NO_BUFS);`
`308`	`308`
`@@ -360,14 +360,11 @@ static void processTransmit(otInstance *aInstance)`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`// Notify if more`
`363`		`- if (sHeadOutput != NULL)`
`364`		`- {`
`365`		`- otrTaskNotifyGive();`
`366`		`- }`
`367`		`- else`
	`363`	`+ if (sHeadOutput == NULL)`
`368`	`364`	`{`
`369`	`365`	`sLastOutput = NULL;`
`370`	`366`	`}`
	`367`	`+ otrTaskNotifyGive();`
`371`	`368`
`372`	`369`	`exit:`
`373`	`370`	`if (error != OT_ERROR_NONE)`