Skip to content

Commit e4a2e2e

Browse files
hexqihexqi
authored
fix(ci): remove workflow-level env block exposing secrets (#111)
1 parent 846f264 commit e4a2e2e

5 files changed

Lines changed: 17 additions & 45 deletions

File tree

‎.github/workflows/deploy-obs-docs.yml‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ on:
1414
required: false
1515
type: string
1616

17-
env:
18-
# 在 GitHub 项目源码仓库 → 项目的 Settings → Secrets(Actions 里的 Repository secrets) 里提前建好以下变量
19-
HUAWEI_CLOUD_AK: ${{ secrets.HUAWEI_CLOUD_AK }}
20-
HUAWEI_CLOUD_SK: ${{ secrets.HUAWEI_CLOUD_SK }}
21-
HUAWEI_CLOUD_ENDPOINT: ${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
22-
HUAWEI_CLOUD_BUCKET: ${{ secrets.HUAWEI_CLOUD_BUCKET }}
23-
2417
permissions:
2518
contents: read
2619
pages: write
@@ -89,12 +82,12 @@ jobs:
8982
- name: Upload to OBS
9083
run: |
9184
# 一次性配置 AK/SK/endpoint
92-
obsutil config -i=${{ env.HUAWEI_CLOUD_AK }} \
93-
-k=${{ env.HUAWEI_CLOUD_SK }} \
94-
-e=${{ env.HUAWEI_CLOUD_ENDPOINT }}
85+
obsutil config -i=${{ secrets.HUAWEI_CLOUD_AK }} \
86+
-k=${{ secrets.HUAWEI_CLOUD_SK }} \
87+
-e=${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
9588
9689
# 把本地 dist/ 目录整站同步到桶根目录
9790
echo "needs.build.outputs.version: ${{ needs.build.outputs.version }}"
9891
mv packages/opentiny-docs/dist ${{ needs.build.outputs.version }}
99-
obsutil cp ${{ needs.build.outputs.version }} obs://${{ env.HUAWEI_CLOUD_BUCKET }}/tiny-openTiny-docs/ -r -f
92+
obsutil cp ${{ needs.build.outputs.version }} obs://${{ secrets.HUAWEI_CLOUD_BUCKET }}/tiny-openTiny-docs/ -r -f
10093

‎.github/workflows/deploy-obs-tech-college.yml‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,6 @@ on:
1515
required: false
1616
type: string
1717

18-
env:
19-
# 在 GitHub 项目源码仓库 → 项目的 Settings → Secrets(Actions 里的 Repository secrets) 里提前建好以下变量
20-
HUAWEI_CLOUD_AK: ${{ secrets.HUAWEI_CLOUD_AK }}
21-
HUAWEI_CLOUD_SK: ${{ secrets.HUAWEI_CLOUD_SK }}
22-
HUAWEI_CLOUD_ENDPOINT: ${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
23-
HUAWEI_CLOUD_BUCKET: ${{ secrets.HUAWEI_CLOUD_BUCKET }}
24-
2518
permissions:
2619
contents: read
2720
pages: write
@@ -107,11 +100,11 @@ jobs:
107100
- name: Upload to OBS
108101
run: |
109102
# 一次性配置 AK/SK/endpoint
110-
obsutil config -i=${{ env.HUAWEI_CLOUD_AK }} \
111-
-k=${{ env.HUAWEI_CLOUD_SK }} \
112-
-e=${{ env.HUAWEI_CLOUD_ENDPOINT }}
103+
obsutil config -i=${{ secrets.HUAWEI_CLOUD_AK }} \
104+
-k=${{ secrets.HUAWEI_CLOUD_SK }} \
105+
-e=${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
113106
114107
# 把本地 dist/ 目录整站同步到桶根目录
115108
echo "needs.build.outputs.version: ${{ needs.build.outputs.version }}"
116109
mv packages/tech-college/dist ${{ needs.build.outputs.version }}
117-
obsutil cp ${{ needs.build.outputs.version }} obs://${{ env.HUAWEI_CLOUD_BUCKET }}/opentiny-tech-college/ -r -f
110+
obsutil cp ${{ needs.build.outputs.version }} obs://${{ secrets.HUAWEI_CLOUD_BUCKET }}/opentiny-tech-college/ -r -f

‎.github/workflows/deploy-obs-tiny-engine.yml‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,6 @@ on:
1414
required: false
1515
type: string
1616

17-
env:
18-
# 在 GitHub 项目源码仓库 → 项目的 Settings → Secrets(Actions 里的 Repository secrets) 里提前建好以下变量
19-
HUAWEI_CLOUD_AK: ${{ secrets.HUAWEI_CLOUD_AK }}
20-
HUAWEI_CLOUD_SK: ${{ secrets.HUAWEI_CLOUD_SK }}
21-
HUAWEI_CLOUD_ENDPOINT: ${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
22-
HUAWEI_CLOUD_BUCKET: ${{ secrets.HUAWEI_CLOUD_BUCKET }}
23-
2417
permissions:
2518
contents: read
2619
pages: write
@@ -104,11 +97,11 @@ jobs:
10497
- name: Upload to OBS
10598
run: |
10699
# 一次性配置 AK/SK/endpoint
107-
obsutil config -i=${{ env.HUAWEI_CLOUD_AK }} \
108-
-k=${{ env.HUAWEI_CLOUD_SK }} \
109-
-e=${{ env.HUAWEI_CLOUD_ENDPOINT }}
100+
obsutil config -i=${{ secrets.HUAWEI_CLOUD_AK }} \
101+
-k=${{ secrets.HUAWEI_CLOUD_SK }} \
102+
-e=${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
110103
111104
# 把本地 packages/tiny-engine-portal/dist/ 目录整站同步到桶根目录
112105
echo "needs.build.outputs.version: ${{ needs.build.outputs.version }}"
113106
mv packages/tiny-engine-portal/dist ${{ needs.build.outputs.version }}
114-
obsutil cp ${{ needs.build.outputs.version }} obs://${{ env.HUAWEI_CLOUD_BUCKET }}/lowcode-portal/ -r -f
107+
obsutil cp ${{ needs.build.outputs.version }} obs://${{ secrets.HUAWEI_CLOUD_BUCKET }}/lowcode-portal/ -r -f

‎.github/workflows/deploy-obs.yml‎

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,6 @@ on:
1515
required: false
1616
type: string
1717

18-
env:
19-
# 在 GitHub 项目源码仓库 → 项目的 Settings → Secrets(Actions 里的 Repository secrets) 里提前建好以下变量
20-
HUAWEI_CLOUD_AK: ${{ secrets.HUAWEI_CLOUD_AK }}
21-
HUAWEI_CLOUD_SK: ${{ secrets.HUAWEI_CLOUD_SK }}
22-
HUAWEI_CLOUD_ENDPOINT: ${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
23-
HUAWEI_CLOUD_BUCKET: ${{ secrets.HUAWEI_CLOUD_BUCKET }}
24-
2518
permissions:
2619
contents: read
2720
pages: write
@@ -114,11 +107,11 @@ jobs:
114107
- name: Upload to OBS
115108
run: |
116109
# 一次性配置 AK/SK/endpoint
117-
obsutil config -i=${{ env.HUAWEI_CLOUD_AK }} \
118-
-k=${{ env.HUAWEI_CLOUD_SK }} \
119-
-e=${{ env.HUAWEI_CLOUD_ENDPOINT }}
110+
obsutil config -i=${{ secrets.HUAWEI_CLOUD_AK }} \
111+
-k=${{ secrets.HUAWEI_CLOUD_SK }} \
112+
-e=${{ secrets.HUAWEI_CLOUD_ENDPOINT }}
120113
121114
# 把本地 dist/ 目录整站同步到桶根目录
122115
echo "needs.build.outputs.version: ${{ needs.build.outputs.version }}"
123116
mv dist ${{ needs.build.outputs.version }}
124-
obsutil cp ${{ needs.build.outputs.version }} obs://${{ env.HUAWEI_CLOUD_BUCKET }}/tinyui-design/ -r -f
117+
obsutil cp ${{ needs.build.outputs.version }} obs://${{ secrets.HUAWEI_CLOUD_BUCKET }}/tinyui-design/ -r -f

‎packages/tiny-engine-portal/vite.config.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ const config = {
3939
}
4040
},
4141
define: {
42-
'process.env': process.env
42+
'process.env': {}
4343
},
4444
optimizeDeps: {
4545
esbuildOptions: {

0 commit comments

Comments
 (0)