Creates a set of valid combos and introduces strictValidCombos config item

Author: amy-corson-ibigroup

Diff for: example-config.yml

@@ -363,6 +363,9 @@ itinerary:
   # Filters out trips returned by OTP by default, unless specifically requested.
   # e.g. filters out walk-only itineraries if user has not explicitly asked for them.
   strictItineraryFiltering: false
+  # Whether to filter out itineraries that do not match our list of valid mode combinations
+  # (e.g. "WALK" + "DRIVE")
+  strictValidCombos: false
   # Whether to render route names and colors in the blocks inside
   # the batch ui rows
   renderRouteNamesInBlocks: true

Diff for: lib/actions/apiV2.js

@@ -73,6 +73,17 @@ const { randId } = coreUtils.storage
 
 const LIGHT_GRAY = '666666'
 
+const VALID_COMBOS = [
+  ['WALK'],
+  ['WALK', 'PERSONAL'],
+  ['WALK', 'TRANSIT', 'SHARED'],
+  ['WALK', 'SHARED'],
+  ['WALK', 'TRANSIT'],
+  ['WALK', 'TRANSIT', 'PERSONAL'],
+  ['WALK', 'TRANSIT', 'CAR'],
+  ['CAR']
+]
+
 function formatRecentPlace(place) {
   return convertToPlace({
     ...place,
@@ -982,6 +993,7 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
       {}
 
     const strictModes = !!config?.itinerary?.strictItineraryFiltering
+    const strictValidCombos = !!config?.itinerary?.strictValidCombos
 
     // Filter mode definitions based on active mode keys
     const activeModeButtons = config.modes?.modeButtons.filter((mb) =>
@@ -1114,6 +1126,22 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
                     activeModeStrings.includes(SIMPLIFICATIONS[leg.mode])
                   )
                 )
+                // If "strictValidCombos" is enabled, filter out itineraries that do not match our list of valid mode combinations
+                // (e.g. "WALK" + "DRIVE")
+                // TODO: Remove this and VALID_COMBOS once we switch to planConnection API
+                if (strictValidCombos) {
+                  filteredItineraries = filteredItineraries.filter((itin) => {
+                    const modeCombo = Array.from(
+                      new Set(itin.legs.map((leg) => SIMPLIFICATIONS[leg.mode]))
+                    )
+                    return !!VALID_COMBOS.find(
+                      (vc) =>
+                        modeCombo.every((m) => vc.includes(m)) &&
+                        vc.every((m) => modeCombo.includes(m))
+                    )
+                  })
+                }
+
                 // ... Otherwise return all itineraries.
               }