Merge pull request #1366 from opentripplanner/strict-valid-mode-combos

acceptableValidModeCombos configuration

Author: amy-corson-ibigroup

Diff for: example-config.yml

@@ -348,6 +348,18 @@ routingTypes:
 
 # Itinerary options
 itinerary:
+  # Provides an array of valid mode combinations that returned itineraries will be filtered against
+  # If left blank, all itineraries deemed valid by OTP will be returned
+  validModeCombinations: [ 
+    ['WALK'],
+    ['WALK', 'PERSONAL'],
+    ['WALK', 'TRANSIT', 'SHARED'],
+    ['WALK', 'SHARED'],
+    ['WALK', 'TRANSIT'],
+    ['WALK', 'TRANSIT', 'PERSONAL'],
+    ['WALK', 'TRANSIT', 'CAR'],
+    ['CAR'] 
+  ]
   # Show fares for each transit leg (false if omitted).
   # (Requires using LineItinerary.)
   showRouteFares: false

Diff for: lib/actions/apiV2.js

@@ -982,6 +982,7 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
       {}
 
     const strictModes = !!config?.itinerary?.strictItineraryFiltering
+    const validModeCombinations = config?.itinerary?.validModeCombinations
 
     // Filter mode definitions based on active mode keys
     const activeModeButtons = config.modes?.modeButtons.filter((mb) =>
@@ -1114,6 +1115,22 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
                     activeModeStrings.includes(SIMPLIFICATIONS[leg.mode])
                   )
                 )
+                // If "acceptableValidModeCombos" is provided, filter out itineraries that do not match our list of valid mode combinations
+                // (e.g. "WALK" + "DRIVE")
+                // TODO: Remove this once we switch to planConnection API
+                if (validModeCombinations?.length > 0) {
+                  filteredItineraries = filteredItineraries.filter((itin) => {
+                    const modeCombo = Array.from(
+                      new Set(itin.legs.map((leg) => SIMPLIFICATIONS[leg.mode]))
+                    )
+                    return validModeCombinations.find(
+                      (vc) =>
+                        modeCombo.length === vc.length &&
+                        vc.every((m) => modeCombo.includes(m))
+                    )
+                  })
+                }
+
                 // ... Otherwise return all itineraries.
               }