Skip to content

Commit 7b42339

Browse files
authored
Merge pull request #186 from opentripplanner/itin-body-set-active-leg
fix(line-itin/itinerary-body): Use setActiveLeg from NarrativeItineraries
2 parents 702520b + d694c3a commit 7b42339

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

Diff for: lib/components/narrative/line-itin/connected-itinerary-body.js

-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import { connect } from 'react-redux'
1010
import styled from 'styled-components'
1111

1212
import { showLegDiagram } from '../../../actions/map'
13-
import { setActiveLeg } from '../../../actions/narrative'
1413
import { setViewedTrip } from '../../../actions/ui'
1514
import TransitLegSubheader from './connected-transit-leg-subheader'
1615
import TripDetails from '../connected-trip-details'
@@ -82,7 +81,6 @@ const mapStateToProps = (state, ownProps) => {
8281
}
8382

8483
const mapDispatchToProps = {
85-
setActiveLeg,
8684
setViewedTrip,
8785
showLegDiagram
8886
}

Diff for: lib/components/narrative/line-itin/line-itinerary.js

+9-1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export default class LineItinerary extends NarrativeItinerary {
5050
itinerary,
5151
itineraryFooter,
5252
LegIcon,
53+
setActiveLeg,
5354
showRealtimeAnnotation,
5455
onClick,
5556
timeFormat
@@ -75,7 +76,14 @@ export default class LineItinerary extends NarrativeItinerary {
7576
/>
7677
{showRealtimeAnnotation && <SimpleRealtimeAnnotation />}
7778
{active || expanded
78-
? <ItineraryBody itinerary={itinerary} LegIcon={LegIcon} />
79+
? <ItineraryBody
80+
itinerary={itinerary}
81+
LegIcon={LegIcon}
82+
// Don't use setActiveLeg as an import
83+
// (will cause error when clicking on itinerary suymmary).
84+
// Use the one passed by NarrativeItineraries instead.
85+
setActiveLeg={setActiveLeg}
86+
/>
7987
: null}
8088
{itineraryFooter}
8189
</LineItineraryContainer>

Diff for: lib/components/narrative/narrative-itineraries.js

+3
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,9 @@ const mapStateToProps = (state, ownProps) => {
100100
}
101101

102102
const mapDispatchToProps = (dispatch, ownProps) => {
103+
// FIXME: update signature of these methods,
104+
// so that only one argument is passed,
105+
// e.g. setActiveLeg({ index, leg })
103106
return {
104107
setActiveItinerary: index => {
105108
dispatch(setActiveItinerary({index}))

0 commit comments

Comments
 (0)