Address PR feedback

Author: amy-corson-ibigroup

Diff for: example-config.yml

@@ -350,7 +350,7 @@ routingTypes:
 itinerary:
   # Provides an array of valid mode combinations that returned itineraries will be filtered against
   # If left blank, all itineraries deemed valid by OTP will be returned
-  acceptableValidModeCombos: [ 
+  validModeCombinations: [ 
     ['WALK'],
     ['WALK', 'PERSONAL'],
     ['WALK', 'TRANSIT', 'SHARED'],

Diff for: lib/actions/apiV2.js

@@ -982,8 +982,7 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
       {}
 
     const strictModes = !!config?.itinerary?.strictItineraryFiltering
-    const acceptableValidModeCombos =
-      config?.itinerary?.acceptableValidModeCombos
+    const validModeCombinations = config?.itinerary?.validModeCombinations
 
     // Filter mode definitions based on active mode keys
     const activeModeButtons = config.modes?.modeButtons.filter((mb) =>
@@ -1119,15 +1118,14 @@ export function routingQuery(searchId = null, updateSearchInReducer) {
                 // If "acceptableValidModeCombos" is provided, filter out itineraries that do not match our list of valid mode combinations
                 // (e.g. "WALK" + "DRIVE")
                 // TODO: Remove this once we switch to planConnection API
-                if (acceptableValidModeCombos?.length > 0) {
-                  console.log(!!acceptableValidModeCombos)
+                if (validModeCombinations?.length > 0) {
                   filteredItineraries = filteredItineraries.filter((itin) => {
                     const modeCombo = Array.from(
                       new Set(itin.legs.map((leg) => SIMPLIFICATIONS[leg.mode]))
                     )
-                    return !!acceptableValidModeCombos.find(
+                    return validModeCombinations.find(
                       (vc) =>
-                        modeCombo.every((m) => vc.includes(m)) &&
+                        modeCombo.length === vc.length &&
                         vc.every((m) => modeCombo.includes(m))
                     )
                   })