refactor: address PR #162 comments

Author: landonreed

Diff for: lib/actions/ui.js

@@ -78,16 +78,7 @@ export function matchContentToUrl (location) {
         dispatch(setMapCenter({ lat, lon }))
         dispatch(setMapZoom({ zoom }))
         // If router ID is provided, override the default routerId.
-        if (routerId) {
-          // This is a somewhat hidden element of the trip planner, so show a
-          // confirmation message to the user to ensure they are aware of what
-          // is happening.
-          const useAltRouterId = window.confirm(
-            `The trip planner's router is set to ${routerId}.\n\nClick OK to confirm or Cancel to use the default router.\n\nNote: new sessions opened with URLs copied from this tab's address bar will not reference the correct router (must contain the #/start/lat/lon/zoom/router prefix).`
-          )
-          if (useAltRouterId) dispatch(setRouterId(routerId))
-          else dispatch(setRouterId(null))
-        }
+        if (routerId) dispatch(setRouterId(routerId))
         dispatch(setMainPanelContent(null))
         break
       // For any other route path, just revert to default panel.

Diff for: lib/reducers/create-otp-reducer.js

@@ -128,9 +128,9 @@ export function getInitialState (userDefinedConfig, initialQuery) {
   // Note: this mechanism assumes that the OTP API path is otp/routers/default.
   const routerId = window.sessionStorage.getItem('routerId')
   // If routerId is found, update the config.api.path (keep the original config
-  // value at _path in case it needs to be reverted.)
+  // value at originalPath in case it needs to be reverted.)
   if (routerId) {
-    config.api._path = userDefinedConfig.api.path
+    config.api.originalPath = userDefinedConfig.api.path
     config.api.path = `/otp/routers/${routerId}`
   }
   let queryModes = currentQuery.mode.split(',')
@@ -555,13 +555,13 @@ function createOtpReducer (config, initialQuery) {
         })
       case 'SET_ROUTER_ID':
         const routerId = action.payload
-        // Store original path value in _path variable.
-        const _path = config.api._path || config.api.path || '/otp/routers/default'
+        // Store original path value in originalPath variable.
+        const originalPath = config.api.originalPath || config.api.path || '/otp/routers/default'
         const path = routerId
           ? `/otp/routers/${routerId}`
           // If routerId is null, revert to the original config's API path (or
           // the standard path if that is not found).
-          : _path
+          : originalPath
         // Store routerId in session storage (persists through page reloads but
         // not when a new tab/window is opened).
         if (routerId) window.sessionStorage.setItem('routerId', routerId)
@@ -570,7 +570,7 @@ function createOtpReducer (config, initialQuery) {
           config: {
             api: {
               path: { $set: path },
-              _path: { $set: _path }
+              originalPath: { $set: originalPath }
             }
           }
         })