Skip to content

Fix blank screen error on set locations #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Fix blank screen error on set locations #134

merged 1 commit into from
Feb 20, 2020

Conversation

landonreed
Copy link
Member

fix #133

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now, but seems like this is a temporary disabling of some problem code that shouldn't entirely close #133. So let's re-open that issue if this PR closes it.

@evansiroky evansiroky removed their assignment Feb 19, 2020
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Evan's comments.

@landonreed
Copy link
Member Author

I'm in agreement here as well. Thanks, all.

@evansiroky
Copy link
Contributor

🎉 This PR is included in version 0.13.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@binh-dam-ibigroup binh-dam-ibigroup added the otp-rr-only Indicates whether changes only apply to otp-rr (and not otp-ui) label Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
otp-rr-only Indicates whether changes only apply to otp-rr (and not otp-ui) released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting from / to location via location search on mobile causes a white screen
3 participants