REVIEW: address feedback

Author: wfaderhold21

src/components/tl/ucp/alltoall/alltoall.c

@@ -75,13 +75,12 @@ ucc_status_t ucc_tl_ucp_alltoall_onesided_init(ucc_base_coll_args_t *coll_args,
                                                ucc_base_team_t      *team,
                                                ucc_coll_task_t     **task_h)
 {
-    ucc_tl_ucp_team_t  *tl_team  = ucc_derived_of(team, ucc_tl_ucp_team_t);
-    ucc_status_t        status   = UCC_OK;
-    ucc_tl_ucp_task_t  *task;
+    ucc_tl_ucp_team_t *tl_team = ucc_derived_of(team, ucc_tl_ucp_team_t);
+    ucc_tl_ucp_task_t *task;
+    ucc_status_t       status;
 
     ALLTOALL_TASK_CHECK(coll_args->args, tl_team);
 
-    /* memory handles do not support work buffers, so check here */
     if (!(coll_args->args.mask & UCC_COLL_ARGS_FIELD_GLOBAL_WORK_BUFFER)) {
         tl_error(UCC_TL_TEAM_LIB(tl_team),
                  "global work buffer not provided nor associated with team");
@@ -115,4 +114,4 @@ ucc_status_t ucc_tl_ucp_alltoall_onesided_init(ucc_base_coll_args_t *coll_args,
     }
 out:
     return status;
-}
+}

src/components/tl/ucp/tl_ucp_coll.h

@@ -89,8 +89,6 @@ enum ucc_tl_ucp_task_flags {
     UCC_TL_UCP_TASK_FLAG_SUBSET      = UCC_BIT(0),
     /* indicates usage of dynamic segments */
     UCC_TL_UCP_TASK_FLAG_USE_DYN_SEG = UCC_BIT(1),
-    /* indicates onesided operations have been started */
-    UCC_TL_UCP_TASK_FLAG_OPS_STARTED = UCC_BIT(2),
 };
 
 typedef struct ucc_tl_ucp_allreduce_sw_pipeline

src/components/tl/ucp/tl_ucp_sendrecv.h

@@ -597,6 +597,7 @@ static inline ucc_status_t ucc_tl_ucp_put_nb(void *buffer, void *target,
     }
 
     ucp_status = ucp_put_nbx(ep, buffer, msglen, rva, rkey, &req_param);
+
     task->onesided.put_posted++;
     if (UCS_OK != ucp_status) {
         if (UCS_PTR_IS_ERR(ucp_status)) {
@@ -653,6 +654,7 @@ static inline ucc_status_t ucc_tl_ucp_get_nb(void *buffer, void *target,
     }
 
     ucp_status = ucp_get_nbx(ep, buffer, msglen, rva, rkey, &req_param);
+
     task->onesided.get_posted++;
     if (UCS_OK != ucp_status) {
         if (UCS_PTR_IS_ERR(ucp_status)) {
@@ -670,11 +672,11 @@ static inline ucc_status_t ucc_tl_ucp_atomic_inc(void *     target,
                                                  ucc_mem_map_mem_h *dest_memh,
                                                  ucc_tl_ucp_team_t *team)
 {
-    ucp_request_param_t req_param   = {0};
-    int                 segment     = 0;
-    uint64_t            one         = 1;
-    ucp_rkey_h          rkey        = NULL;
-    uint64_t            rva         = 0;
+    ucp_request_param_t req_param = {0};
+    int                 segment   = 0;
+    uint64_t            one       = 1;
+    ucp_rkey_h          rkey      = NULL;
+    uint64_t            rva       = 0;
     ucs_status_ptr_t    ucp_status;
     ucc_status_t        status;
     ucp_ep_h            ep;

src/ucc/api/ucc.h

@@ -902,8 +902,8 @@ typedef ucc_oob_coll_t ucc_team_oob_coll_t;
  *  @ingroup UCC_CONTEXT_DT
  */
 typedef struct ucc_mem_map {
-    void  *address;  /*!< the address of a buffer to be attached to a UCC context */
-    size_t len;      /*!< the length of the buffer */
+    void *   address; /*!< the address of a buffer to be attached to a UCC context */
+    size_t   len;     /*!< the length of the buffer */
 } ucc_mem_map_t;
 
 /**
@@ -1710,7 +1710,7 @@ typedef enum {
                                                             Note, the status is not guaranteed
                                                             to be global on all the processes
                                                             participating in the collective.*/
-    UCC_COLL_ARGS_FLAG_MEM_MAPPED_BUFFERS   = UCC_BIT(7),  /*!< If set, both src
+    UCC_COLL_ARGS_FLAG_MEM_MAPPED_BUFFERS   = UCC_BIT(7), /*!< If set, both src
                                                             and dst buffers
                                                             reside in a memory
                                                             mapped region.
@@ -1720,7 +1720,7 @@ typedef enum {
                                                             the src_memh memory
                                                             handle is an array of
                                                             global handles. */
-    UCC_COLL_ARGS_FLAG_DST_MEMH_GLOBAL      = UCC_BIT(9)  /*!< If set, indicates
+    UCC_COLL_ARGS_FLAG_DST_MEMH_GLOBAL      = UCC_BIT(9), /*!< If set, indicates
                                                             the dst_memh memory
                                                             handle is an array of
                                                             global handles. */

test/mpi/test_alltoallv.cc

@@ -55,7 +55,6 @@ TestAlltoallv::TestAlltoallv(ucc_test_team_t &_team, TestCaseParams &params) :
 
     MPI_Comm_rank(team.comm, &rank);
     MPI_Comm_size(team.comm, &nprocs);
-    //MPI_Barrier(team.comm);
 
     if (TEST_SKIP_NONE != skip_reduce(test_max_size < (msgsize * nprocs),
                                       TEST_SKIP_MEM_LIMIT, team.comm)) {