UCM: Propagate memory attributes in allocation events - v1.22.x - #11655
Merged
gleon99 merged 2 commits intoJul 15, 2026
Conversation
| if (ucs_unlikely((status == UCS_ERR_UNSUPPORTED) || | ||
| (mem_info.type == UCS_MEMORY_TYPE_UNKNOWN))) { | ||
| (mem_info.type == UCS_MEMORY_TYPE_UNKNOWN) || | ||
| (mem_info.sys_dev == UCS_SYS_DEVICE_ID_UNKNOWN))) { |
Contributor
There was a problem hiding this comment.
Just noticed this, shouldn't it have && mem_info.mem_flags == 0 here?
Contributor
Author
There was a problem hiding this comment.
Intentional — CUDA copy needs sys_dev regardless of mem_flags. We actually removed that check in the original PR after review, so I’d keep the backport consistent with master.
Contributor
There was a problem hiding this comment.
CUDA copy needs sys_dev regardless of mem_flags
Why? Can it not lead to excessive queries?
We actually removed that check in the original PR after review, so I’d keep the backport consistent with master.
Sure, but just want to make sure this is not an issue later
Contributor
|
@gleon99 can we merge? |
Contributor
Author
Pushed last minor change @tomerg-nvidia |
tomerg-nvidia
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Port #11646