Skip to content

COVERITY: Update to the 2023 Cov module - #9856

Closed
Alexey-Rivkin wants to merge 1 commit into
openucx:masterfrom
Alexey-Rivkin:topic/cov_2023
Closed

COVERITY: Update to the 2023 Cov module#9856
Alexey-Rivkin wants to merge 1 commit into
openucx:masterfrom
Alexey-Rivkin:topic/cov_2023

Conversation

@Alexey-Rivkin

@Alexey-Rivkin Alexey-Rivkin commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

What

Update to the 2023 Cov module.

Summary by CodeRabbit

  • Chores
    • Updated code analysis tooling to a newer version for improved vulnerability detection.
    • Updated build environment container to the latest Red Hat Enterprise Linux platform for enhanced compatibility and security.

@Alexey-Rivkin
Alexey-Rivkin requested a review from dpressle April 30, 2024 12:57
@Alexey-Rivkin
Alexey-Rivkin marked this pull request as draft April 30, 2024 15:57
@Alexey-Rivkin
Alexey-Rivkin force-pushed the topic/cov_2023 branch 4 times, most recently from 6c000ae to 1a15c5b Compare May 9, 2024 20:10
@Alexey-Rivkin
Alexey-Rivkin marked this pull request as ready for review May 9, 2024 20:10
@Alexey-Rivkin

Copy link
Copy Markdown
Contributor Author

/azp run UCX PR

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@coderabbitai

coderabbitai Bot commented Nov 4, 2025

Copy link
Copy Markdown

Walkthrough

Two configuration files were updated to upgrade the Coverity toolchain. The CI pipeline container image was changed from coverity_rh7 to rhel90, and the Coverity module reference was updated from version 2019.12 to 2023.12.

Changes

Cohort / File(s) Change Summary
Coverity CI Configuration
buildlib/pr/main.yml
Updated container image for Coverity job from coverity_rh7 to rhel90
Coverity Module Reference
buildlib/tools/coverity.sh
Updated COV_MODULE constant from "tools/cov-2019.12" to "tools/cov-2023.12"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Both changes are straightforward configuration value updates with no logic modifications
  • Verify that the new container image rhel90 exists and is properly configured
  • Confirm that the Coverity module version cov-2023.12 is available in the expected module path

Poem

🐰 Hops of joy through Coverity's lane,
Old rhel7 fades, rhel90 takes the reign,
2019 to 2023 we leap,
Fresher tools, the code runs deep!

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly reflects the main changes: updating Coverity from the 2019 module to the 2023 module, which are the primary modifications across both affected files.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6969a83 and 378df21.

📒 Files selected for processing (2)
  • buildlib/pr/main.yml (1 hunks)
  • buildlib/tools/coverity.sh (1 hunks)
🔇 Additional comments (1)
buildlib/tools/coverity.sh (1)

7-7: Module version update is consistent and well-integrated.

The Coverity module has been updated to cov-2023.12, which is correctly referenced in both the modules_for_coverity() load function (line 49) and the modules_for_coverity_unload() unload function (line 66). The variable follows the expected naming convention and is defined at a single point.

The PR description links to IT ticket REQ01174026, which suggests the module availability is being coordinated separately. Confirm that the tools/cov-2023.12 module is available in the expected IT storage location before merging.


Comment @coderabbitai help to get the list of available commands and usage tips.

@Alexey-Rivkin

Copy link
Copy Markdown
Contributor Author

Superseded by #11739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant