Skip to content

Do we need command=show-menu and command=hide-menu? #1442

@josepharhar

Description

@josepharhar

Right now we have three menu commands:

  1. command=toggle-menu
  2. command=show-menu
  3. command=hide-menu

In theory the difference between toggle-menu and show-menu is that toggle-menu can close submenus when it is activated, but I am removing part of the closing functionality from toggle-menu in order to implement the resolution about moving focus into a submenu, and the only remaining difference is that toggle-menu has interest invoker behaviors.

When I was making a demo with this feature a week ago, I mistakenly thought that show-menu was the preferred way to make submenus, and I should have used toggle-menu. I was surprised when it didn't work as expected. With this in mind, I think it would make sense to remove show-menu and just have toggle-menu.

Similiarly, I don't see a great use case for command=hide-menu. The only really valid thing I can think of is to have a menuitem inside of a menulist which closes the menulist, but I've never seen such a thing in any application.

Can we just remove command=show-menu and command=hide-menu to save developer confusion about how to create menu elements?

Metadata

Metadata

Assignees

No one assigned

    Labels

    menuMenu elements proposal

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions