Commit 9e9222d
committed
Fix #70: stop calling logging.basicConfig() at import time
gtfparse called logging.basicConfig(level=logging.INFO) at module import
in three modules (read_gtf, attribute_parsing, create_missing_features).
As a library this is an anti-pattern: it configures the root logger on
behalf of the importing application, adding a handler and forcing the
INFO level onto everyone's root logger — hijacking the host app's logging.
Remove the basicConfig() calls and route the remaining log statements
through the module-level `logger` (logging.getLogger(__name__)) instead
of the root-logger convenience functions logging.info(...), which would
otherwise implicitly re-trigger basicConfig().
Configuring handlers/levels is now left entirely to the application, per
the standard library logging guidance for libraries.
Claude-Session: https://claude.ai/code/session_014fNxSBm5zvdsDNwN3nhmpS1 parent 03668a3 commit 9e9222d
3 files changed
Lines changed: 5 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
18 | 17 | | |
19 | 18 | | |
20 | 19 | | |
| |||
103 | 102 | | |
104 | 103 | | |
105 | 104 | | |
106 | | - | |
| 105 | + | |
107 | 106 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | 18 | | |
20 | 19 | | |
21 | 20 | | |
| |||
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | | - | |
| 60 | + | |
62 | 61 | | |
63 | | - | |
| 62 | + | |
64 | 63 | | |
65 | 64 | | |
66 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | 22 | | |
24 | 23 | | |
25 | 24 | | |
| |||
406 | 405 | | |
407 | 406 | | |
408 | 407 | | |
409 | | - | |
| 408 | + | |
410 | 409 | | |
411 | 410 | | |
412 | | - | |
| 411 | + | |
413 | 412 | | |
414 | 413 | | |
415 | 414 | | |
| |||
0 commit comments