From d7504b225653e8dcf253e1d6564d959cb36b0ffc Mon Sep 17 00:00:00 2001 From: Vladimir Zlobin Date: Thu, 12 Feb 2026 12:11:40 +0400 Subject: [PATCH 1/3] Extend copilot-instructions.md From https://github.com/openvinotoolkit/openvino.genai/pull/2707#discussion_r2793621035 --- .github/copilot-instructions.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index f44aa3ee48..8c8c918cea 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -33,11 +33,12 @@ When analyzing a Pull Request, follow this protocol: 12. Make sure the function names are descriptive. 13. Check for variables with different names but similar meaning or aliasing. 14. Avoid duplicate code. Ensure that common functionality is extracted into reusable functions or utilities. -15. Avoid pronouns in comments and names to make the statements concise. -16. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`. -17. `debug_utils.hpp` must never be included. -18. Assumptions on user behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead. -19. Samples: +15. Initialize containers with values instead of constructing an empty container and immediately inserting values. +16. Avoid pronouns in comments and names to make the statements concise. +17. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`. +18. `debug_utils.hpp` must never be included. +19. Assumptions on user behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead. +20. Samples: * Avoid adding new samples unless there is a strong, clearly justified reason. * Keep command‑line arguments in samples minimal. * Ensure new samples have corresponding tests. From 7052b1e379f6f8459736e04919c344df64c6807a Mon Sep 17 00:00:00 2001 From: Vladimir Zlobin Date: Thu, 12 Feb 2026 12:17:47 +0400 Subject: [PATCH 2/3] Update .github/copilot-instructions.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/copilot-instructions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 8c8c918cea..5bf07b98c4 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -33,7 +33,7 @@ When analyzing a Pull Request, follow this protocol: 12. Make sure the function names are descriptive. 13. Check for variables with different names but similar meaning or aliasing. 14. Avoid duplicate code. Ensure that common functionality is extracted into reusable functions or utilities. -15. Initialize containers with values instead of constructing an empty container and immediately inserting values. +15. When initial container values are known upfront, prefer initializer-list / brace-initialization over constructing an empty container and immediately inserting values. 16. Avoid pronouns in comments and names to make the statements concise. 17. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`. 18. `debug_utils.hpp` must never be included. From 2cab08868f49901c422eaa3b77f48686030034a0 Mon Sep 17 00:00:00 2001 From: Vladimir Zlobin Date: Thu, 12 Feb 2026 12:17:56 +0400 Subject: [PATCH 3/3] Update .github/copilot-instructions.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/copilot-instructions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index 5bf07b98c4..559c255d4f 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -37,7 +37,7 @@ When analyzing a Pull Request, follow this protocol: 16. Avoid pronouns in comments and names to make the statements concise. 17. Unused functions and constructors aren't allowed except for in `debug_utils.hpp`. 18. `debug_utils.hpp` must never be included. -19. Assumptions on user behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead. +19. Assumptions on the user's behalf aren't allowed. For example, the implementation shouldn't adjust config values silently or with a warning; it should throw an exception instead. 20. Samples: * Avoid adding new samples unless there is a strong, clearly justified reason. * Keep command‑line arguments in samples minimal.