-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[TF FE] Support MatrixDiagV3 operation #24498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, keep this way!
build_jenkins |
Hi @duydl, any progress on the next steps? Please finalize PR. |
@rkazants Hi, I have some problem with retrieving attribute from tf graph: attribute always get the fallback value.
I check other ops using this but couldn't see the difference in how attribute passed into tf graph in the pytest file. |
c70f4b5
to
48bf0b5
Compare
I think these are not attributes and should be treat as input tensors and accessed with |
So params could only be either attribute or input and it depend on tf internal? I originally use get_input to get k but get this error:
from this snippet. auto axes = make_shared<v0::Constant>(element::i64, Shape{1}, std::vector<int64_t>{0});
auto k_unsqueezed = make_shared<v0::Unsqueeze>(k_, axes);
auto updated_shape = make_shared<v3::ScatterElementsUpdate>(
zero_padded_diag_shape, // data input
make_shared<v0::Constant>(element::i64, Shape{1}, std::vector<int64_t>{-1}), // indices
k_unsqueezed, // updates
make_shared<v0::Constant>(element::i64, Shape{}, std::vector<int64_t>{0}) // axis
); I expected it is because k is from node input so change to attribute instead. But as it is not possible, do you have any insight? Edit: ie, openVINO ops nodes need to be config with value of |
This PR will be closed in a week because of 2 weeks of no activity. |
Hi, I currently do not have time to try other approaches. I will leave it to others and may reopen the pr to retry if available later. |
Details:
Tickets: